Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(484)

Side by Side Diff: chrome/browser/page_load_metrics/observers/prerender_page_load_metrics_observer.h

Issue 2423383002: [Prerender] first contentful paint histograms. (Closed)
Patch Set: Generalize internal histogram function name Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PRERENDER_PAGE_LOAD_METRICS_O BSERVER_H_
6 #define CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PRERENDER_PAGE_LOAD_METRICS_O BSERVER_H_
7
8 #include "base/macros.h"
9 #include "chrome/browser/page_load_metrics/page_load_metrics_observer.h"
10 #include "url/gurl.h"
11
12 namespace content {
13 class WebContents;
14 }
15
16 namespace prerender {
17 class PrerenderManager;
18 }
19
20 // Observer recording metrics related to prerender.
21 class PrerenderPageLoadMetricsObserver
22 : public page_load_metrics::PageLoadMetricsObserver {
23 public:
24 // Returns a PrerenderPageLoadMetricsObserver, or nullptr if it is not needed.
25 static std::unique_ptr<page_load_metrics::PageLoadMetricsObserver>
pasko 2016/11/21 14:44:36 nit: Add #include <memory> for unique_ptr<> [buil
26 CreateIfNeeded(content::WebContents* web_contents);
27
28 // Public for testing. Normally one should use CreateIfNeeded. Both the
29 // manager and the web_contents must outlive this observer.
30 PrerenderPageLoadMetricsObserver(prerender::PrerenderManager* manager,
31 content::WebContents* web_contents);
32
33 // page_load_metrics::PageLoadMetricsObserver:
34 ObservePolicy OnStart(content::NavigationHandle* navigation_handle,
35 const GURL& currently_committed_url,
36 bool started_in_foreground) override;
37
38 // page_load_metrics::PageLoadMetricsObserver:
39 void OnFirstContentfulPaint(
40 const page_load_metrics::PageLoadTiming& timing,
41 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
42
43 // page_load_metrics::PageLoadMetricsObserver:
44 ObservePolicy OnHidden(
45 const page_load_metrics::PageLoadTiming& timing,
46 const page_load_metrics::PageLoadExtraInfo& extra_info) override;
47
48 protected:
49 void SetNavigationStartTicksForTesting(base::TimeTicks ticks);
50
51 private:
52 prerender::PrerenderManager* const prerender_manager_;
pasko 2016/11/21 14:44:36 that const is nice, I did not know that the style
53 content::WebContents* web_contents_;
54 base::TimeTicks start_ticks_;
55 bool was_hidden_;
56
57 DISALLOW_COPY_AND_ASSIGN(PrerenderPageLoadMetricsObserver);
58 };
59
60 #endif // CHROME_BROWSER_PAGE_LOAD_METRICS_OBSERVERS_PRERENDER_PAGE_LOAD_METRIC S_OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698