Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 2423343002: [builtins] Fixed a Gcc compilation error in src/code-stub-assembler.cc. (Closed)

Created:
4 years, 2 months ago by zhengxing.li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Fixed a Gcc compilation error in src/code-stub-assembler.cc. The CL #40373 (https://codereview.chromium.org/2405253006 ) caused a Gcc compilation error. The error message was: ../src/code-stub-assembler.cc: In member function ‘v8::internal::compiler::Node* v8::internal::CodeStubAssembler::CreateArrayIterator(v8::internal::compiler::Node*, v8::internal::compiler::Node*, v8::internal::compiler::Node*, v8::internal::compiler::Node*, v8::internal::IterationKind)’: ../src/code-stub-assembler.cc:7909:7: error: ‘kBaseMapIndex’ may be used uninitialized in this function [-Werror=maybe-uninitialized] int kBaseMapIndex; ^ cc1plus: all warnings being treated as errors make[1]: *** [/home/zxli/work/google-v8/v8/out/x87.release/obj.target/v8_base/src/code-stub-assembler.o] Error 1 This CL fixed this issue by initalizing kBaseMapIndex to 0. BUG= Committed: https://crrev.com/b275457ecb1dbbfcdec1806fbf69f17b18a8e60a Cr-Commit-Position: refs/heads/master@{#40390}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/code-stub-assembler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
zhengxing.li
PTAL, thanks!
4 years, 2 months ago (2016-10-18 07:24:11 UTC) #2
Benedikt Meurer
LGTM.
4 years, 2 months ago (2016-10-18 07:24:39 UTC) #3
Michael Achenbach
Can you wait with submitting? I want to switch off this warning for gcc.
4 years, 2 months ago (2016-10-18 07:44:47 UTC) #4
zhengxing.li
On 2016/10/18 07:44:47, machenbach (slow) wrote: > Can you wait with submitting? I want to ...
4 years, 2 months ago (2016-10-18 07:46:31 UTC) #5
zhengxing.li
On 2016/10/18 07:46:31, zhengxing.li wrote: > On 2016/10/18 07:44:47, machenbach (slow) wrote: > > Can ...
4 years, 2 months ago (2016-10-18 08:34:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423343002/1
4 years, 2 months ago (2016-10-18 09:19:35 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 09:46:03 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/b275457ecb1dbbfcdec1806fbf69f17b18a8e60a Cr-Commit-Position: refs/heads/master@{#40390}
4 years, 2 months ago (2016-10-18 09:46:27 UTC) #11
caitp
4 years, 2 months ago (2016-10-18 12:38:12 UTC) #12
Message was sent while issue was closed.
On 2016/10/18 09:46:27, commit-bot: I haz the power wrote:
> Patchset 1 (id:??) landed as
> https://crrev.com/b275457ecb1dbbfcdec1806fbf69f17b18a8e60a
> Cr-Commit-Position: refs/heads/master@{#40390}

Sorry about that. Thanks for the fix up.

Powered by Google App Engine
This is Rietveld 408576698