Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(128)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2423323003: Enable multidex for ChromePublic.apk. (Closed)

Created:
4 years, 2 months ago by estevenson
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, mikecase+watch_chromium.org, jbudorick+watch_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable multidex for ChromePublic.apk. DO NOT SUBMIT, this is an experimental CL for testing startup time + RAM changes. Applying this CL results in the following dex cache overhead (via method_counts.py): w/out patch (single dex file):470508 bytes w/patch (classes.dex, renderer): 226736 bytes w/patch (classes.dex + classes2.dex, browser): 566548 bytes Browser process net dex cache overhead w/patch: + 96040 bytes Non browser process net dex cache overhead w/patch (per instance):- 243772 bytes BUG=512357

Patch Set 1 #

Patch Set 2 : Enable multidex for ChromePublic.apk. #

Patch Set 3 : rebase #

Patch Set 4 : Add @MainDex to NativeTest.java #

Patch Set 5 : Enable multidex for ChromePublic.apk. #

Patch Set 6 : Enable multidex for ChromePublic.apk. #

Patch Set 7 : rebase #

Patch Set 8 : Enable multidex for ChromePublic.apk. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M build/android/main_dex_classes.flags View 1 2 chunks +2 lines, -1 line 0 comments Download
M chrome/android/chrome_public_apk_tmpl.gni View 1 1 chunk +3 lines, -3 lines 0 comments Download

Depends on Patchset:

Issue 2501193003 Patch 100001

Messages

Total messages: 25 (25 generated)
estevenson
Description was changed from ========== Enable multidex for ChromePublic.apk. DO NOT SUBMIT, this is an ...
4 years, 1 month ago (2016-11-18 19:20:37 UTC) #1
estevenson
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-18 19:32:22 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423323003/40001
4 years, 1 month ago (2016-11-18 19:33:51 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-18 20:26:15 UTC) #4
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/308486)
4 years, 1 month ago (2016-11-18 20:26:16 UTC) #5
estevenson
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
4 years, 1 month ago (2016-11-18 21:04:00 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423323003/60001
4 years, 1 month ago (2016-11-18 21:04:59 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 1 month ago (2016-11-18 22:00:28 UTC) #8
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/184032)
4 years, 1 month ago (2016-11-18 22:00:29 UTC) #9
estevenson
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
4 years ago (2016-11-24 23:37:06 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423323003/80001
4 years ago (2016-11-24 23:37:13 UTC) #11
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-11-24 23:43:23 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/312655)
4 years ago (2016-11-24 23:43:24 UTC) #13
estevenson
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
4 years ago (2016-12-01 21:19:49 UTC) #14
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423323003/100001
4 years ago (2016-12-01 21:20:17 UTC) #15
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-01 21:23:54 UTC) #16
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/346251)
4 years ago (2016-12-01 21:23:54 UTC) #17
estevenson
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
4 years ago (2016-12-01 21:55:31 UTC) #18
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423323003/120001
4 years ago (2016-12-01 21:55:53 UTC) #19
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-01 22:05:46 UTC) #20
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/316784)
4 years ago (2016-12-01 22:05:47 UTC) #21
estevenson
The CQ bit was checked by estevenson@chromium.org to run a CQ dry run
4 years ago (2016-12-02 22:53:17 UTC) #22
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423323003/140001
4 years ago (2016-12-02 22:54:11 UTC) #23
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years ago (2016-12-02 23:03:49 UTC) #24
commit-bot: I haz the power
4 years ago (2016-12-02 23:03:50 UTC) #25 
Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

Powered by Google App Engine
This is Rietveld 408576698