Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(305)

Issue 2423323002: [builtins] Remove the unused AllocationSite slot from ConstructFrame. (Closed)

Created:
4 years, 2 months ago by Benedikt Meurer
Modified:
4 years, 2 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[builtins] Remove the unused AllocationSite slot from ConstructFrame. This slot is completely unused and always undefined anyways, so there's no need to maintain the slot during object construction. R=yangguo@chromium.org BUG=v8:5049 Committed: https://crrev.com/77419488a971aa9be4da1f167cd5afe0c7537d01 Cr-Commit-Position: refs/heads/master@{#40377}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+55 lines, -61 lines) Patch
M src/builtins/arm/builtins-arm.cc View 3 chunks +8 lines, -8 lines 0 comments Download
M src/builtins/arm64/builtins-arm64.cc View 3 chunks +8 lines, -9 lines 0 comments Download
M src/builtins/ia32/builtins-ia32.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M src/builtins/mips/builtins-mips.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/builtins/mips64/builtins-mips64.cc View 3 chunks +8 lines, -7 lines 0 comments Download
M src/builtins/x64/builtins-x64.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M src/deoptimizer.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/frames.h View 1 chunk +3 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
Benedikt Meurer
4 years, 2 months ago (2016-10-18 05:40:52 UTC) #1
Benedikt Meurer
Hey Yang, Dead code shall be dead. Please take a look. Thanks, Benedikt
4 years, 2 months ago (2016-10-18 05:41:20 UTC) #4
Yang
On 2016/10/18 05:40:52, Benedikt Meurer wrote: lgtm.
4 years, 2 months ago (2016-10-18 05:42:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423323002/1
4 years, 2 months ago (2016-10-18 05:42:41 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 06:06:26 UTC) #9
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 06:07:08 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/77419488a971aa9be4da1f167cd5afe0c7537d01
Cr-Commit-Position: refs/heads/master@{#40377}

Powered by Google App Engine
This is Rietveld 408576698