Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 2423283002: DevTools: Extract ChartViewport out of FlameChart. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
Reviewers:
caseq
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, pfeldman
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: Extract ChartViewport out of FlameChart. The first part of the refactoring. Extract a component that is responsible for navigating over the chart window. BUG=656822 Committed: https://crrev.com/782864fa8e436714667813be00430554c8efc754 Cr-Commit-Position: refs/heads/master@{#425844}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+518 lines, -371 lines) Patch
M third_party/WebKit/Source/devtools/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A third_party/WebKit/Source/devtools/front_end/ui_lazy/ChartViewport.js View 1 chunk +482 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js View 23 chunks +34 lines, -371 lines 2 comments Download
M third_party/WebKit/Source/devtools/front_end/ui_lazy/module.json View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
alph
4 years, 2 months ago (2016-10-17 23:06:57 UTC) #2
caseq
lgtm % comment https://codereview.chromium.org/2423283002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right): https://codereview.chromium.org/2423283002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#newcode52 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:52: * @extends {WebInspector.ChartViewport} I don't think ...
4 years, 2 months ago (2016-10-17 23:26:05 UTC) #3
alph
https://codereview.chromium.org/2423283002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right): https://codereview.chromium.org/2423283002/diff/1/third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js#newcode52 third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:52: * @extends {WebInspector.ChartViewport} On 2016/10/17 23:26:05, caseq wrote: > ...
4 years, 2 months ago (2016-10-17 23:41:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423283002/1
4 years, 2 months ago (2016-10-17 23:42:08 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-18 01:17:23 UTC) #7
commit-bot: I haz the power
4 years, 2 months ago (2016-10-18 01:19:36 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/782864fa8e436714667813be00430554c8efc754
Cr-Commit-Position: refs/heads/master@{#425844}

Powered by Google App Engine
This is Rietveld 408576698