DevTools: Extract ChartViewport out of FlameChart.

DevTools: Extract ChartViewport out of FlameChart.

The first part of the refactoring.
Extract a component that is responsible for navigating over the chart window.

BUG=656822
Committed: https://crrev.com/782864fa8e436714667813be00430554c8efc754
Cr-Commit-Position: refs/heads/master@{#425844}

[alph, 2016-10-17 23:06:56]

alph@chromium.org changed reviewers:
+ caseq@chromium.org

[caseq, 2016-10-17 23:26:05]

lgtm % comment

https://codereview.chromium.org/2423283002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right):

https://codereview.chromium.org/2423283002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:52: *
@extends {WebInspector.ChartViewport}
I don't think inheriting FlameChart form ChartViewport is justified -- can we
rather make it a member perhaps?

[alph, 2016-10-17 23:41:04]

https://codereview.chromium.org/2423283002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js (right):

https://codereview.chromium.org/2423283002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui_lazy/FlameChart.js:52: *
@extends {WebInspector.ChartViewport}
On 2016/10/17 23:26:05, caseq wrote:
> I don't think inheriting FlameChart form ChartViewport is justified -- can we
> rather make it a member perhaps?

I'd keep it the current way and update it later if needed.

[alph, 2016-10-17 23:41:08]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-10-17 23:42:08]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 01:17:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-18 01:19:35]

Description was changed from

==========
DevTools: Extract ChartViewport out of FlameChart.

The first part of the refactoring.
Extract a component that is responsible for navigating over the chart window.

BUG=656822
==========

to

==========
DevTools: Extract ChartViewport out of FlameChart.

The first part of the refactoring.
Extract a component that is responsible for navigating over the chart window.

BUG=656822

Committed: https://crrev.com/782864fa8e436714667813be00430554c8efc754
Cr-Commit-Position: refs/heads/master@{#425844}
==========

[commit-bot: I haz the power, 2016-10-18 01:19:36]

Patchset 1 (id:??) landed as
https://crrev.com/782864fa8e436714667813be00430554c8efc754
Cr-Commit-Position: refs/heads/master@{#425844}