Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(204)

Issue 2423253002: Remove space from omnibox test. (Closed)

Created:
4 years, 2 months ago by brettw
Modified:
4 years, 2 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove space from omnibox test. The original bug for this test (603839) mentions a space in the host name. But removing the space from this test and reverting the patch still makes the test fail, so it seems the test itself is not dependent on the presence of the space. This is part of a patch to make some invalid characters like space and "*" invalid in URLs. Since this test seems not dependent on the presence of the space, I'm changing it in a separate pass. BUG=652808 Committed: https://crrev.com/8b1643a13acc2663941caf671282f23305d00775 Cr-Commit-Position: refs/heads/master@{#425787}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M components/omnibox/browser/omnibox_edit_unittest.cc View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
brettw
4 years, 2 months ago (2016-10-17 20:39:48 UTC) #2
Peter Kasting
LGTM
4 years, 2 months ago (2016-10-17 20:45:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423253002/1
4 years, 2 months ago (2016-10-17 20:57:10 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 22:08:35 UTC) #6
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 22:10:59 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8b1643a13acc2663941caf671282f23305d00775
Cr-Commit-Position: refs/heads/master@{#425787}

Powered by Google App Engine
This is Rietveld 408576698