Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issue 242323003: Crash the renderer when WebSocket fails to allocate an ArrayBuffer to set to a MessageEvent. (Closed)

Created:
6 years, 8 months ago by tyoshino (SeeGerritForStatus)
Modified:
6 years, 7 months ago
Reviewers:
yhirano
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Crash the renderer when WebSocket fails to allocate an ArrayBuffer to set to a MessageEvent. See http://src.chromium.org/viewvc/blink?view=revision&revision=165278. This changed behavior of ArrayBuffer allocation on OOM from crashing to returning null. Add CRASH to keep old behavior. BUG=357356 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=173718

Patch Set 1 #

Patch Set 2 : Use CRASH #

Patch Set 3 : Addressed #2 #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -1 line) Patch
M Source/modules/websockets/WebSocket.cpp View 1 2 3 2 chunks +9 lines, -1 line 0 comments Download
M Source/modules/websockets/WorkerThreadableWebSocketChannel.cpp View 1 2 3 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
tyoshino (SeeGerritForStatus)
6 years, 8 months ago (2014-04-18 04:56:55 UTC) #1
yhirano
ArrayBuffer is created in WorkerThreadableWebSocketChannel as well.
6 years, 8 months ago (2014-04-24 23:55:17 UTC) #2
tyoshino (SeeGerritForStatus)
On 2014/04/24 23:55:17, yhirano wrote: > ArrayBuffer is created in WorkerThreadableWebSocketChannel as well. Done
6 years, 8 months ago (2014-04-25 04:45:10 UTC) #3
yhirano
lgtm
6 years, 8 months ago (2014-04-25 06:15:32 UTC) #4
tyoshino (SeeGerritForStatus)
The CQ bit was checked by tyoshino@chromium.org
6 years, 7 months ago (2014-05-09 03:26:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tyoshino@chromium.org/242323003/60001
6 years, 7 months ago (2014-05-09 03:27:37 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-09 04:41:12 UTC) #7
Message was sent while issue was closed.
Change committed as 173718

Powered by Google App Engine
This is Rietveld 408576698