Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Unified Diff: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h

Issue 2423213002: Remove a bunch of pointless null checks in FrameLoaderClientImpl.
Patch Set: Fix formatting. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h
diff --git a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h
index 0d7db6f9ef8dfa34eaadc6988d51183285687bfa..d1098c7d20f8c76a39a6edd5213685eb32c1b78b 100644
--- a/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h
+++ b/third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h
@@ -130,9 +130,8 @@ class WebEmbeddedWorkerImpl final : public WebEmbeddedWorker,
Persistent<WorkerInspectorProxy> m_workerInspectorProxy;
// 'shadow page' - created to proxy loading requests from the worker.
- // Both WebView and WebFrame objects are close()'ed (where they're
- // deref'ed) when this EmbeddedWorkerImpl is destructed, therefore they
- // are guaranteed to exist while this object is around.
+ // WebView is guarantee to be exist while this object exists, as close() is
+ // called in the destructor.
WebView* m_webView;
Persistent<WebLocalFrameImpl> m_mainFrame;

Powered by Google App Engine
This is Rietveld 408576698