Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2423203002: [Presentation API] add url property to blink PresentationConnection object (Closed)

Created:
4 years, 2 months ago by zhaobin
Modified:
4 years ago
CC:
blink-reviews, chromium-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Presentation API] add url property to blink PresentationConnection object Make PresentationConnection.idl consistent with latest spec https://w3c.github.io/presentation-api/#interface-presentationconnection BUG=654110

Patch Set 1 #

Patch Set 2 : rebase and fix layout test for windows #

Messages

Total messages: 14 (6 generated)
zhaobin
4 years, 2 months ago (2016-10-17 18:28:05 UTC) #3
mlamouri (slow - plz ping)
lg2m but do we have a intent to ship for this? It is adding a ...
4 years, 2 months ago (2016-10-18 16:44:25 UTC) #8
mark a. foltz
On 2016/10/18 at 16:44:25, mlamouri wrote: > lg2m but do we have a intent to ...
4 years, 2 months ago (2016-10-18 23:57:38 UTC) #9
mark a. foltz
I think this was combined with the other change for multiple URL support. Can this ...
4 years ago (2016-12-13 23:41:30 UTC) #10
zhaobin
On 2016/12/13 23:41:30, mark a. foltz wrote: > I think this was combined with the ...
4 years ago (2016-12-13 23:48:13 UTC) #11
mark a. foltz
On 2016/12/13 at 23:48:13, zhaobin wrote: > On 2016/12/13 23:41:30, mark a. foltz wrote: > ...
4 years ago (2016-12-13 23:53:38 UTC) #12
mlamouri (slow - plz ping)
On 2016/12/13 at 23:53:38, mfoltz wrote: > On 2016/12/13 at 23:48:13, zhaobin wrote: > > ...
4 years ago (2016-12-14 00:19:07 UTC) #13
zhaobin
4 years ago (2016-12-14 00:23:38 UTC) #14
On 2016/12/14 00:19:07, mlamouri wrote:
> On 2016/12/13 at 23:53:38, mfoltz wrote:
> > On 2016/12/13 at 23:48:13, zhaobin wrote:
> > > On 2016/12/13 23:41:30, mark a. foltz wrote:
> > > > I think this was combined with the other change for multiple URL
support. 
> Can
> > > > this issue be closed now?
> > > 
> > > Mounir has commented that the multiple url patch
> (https://codereview.chromium.org/2552343009/) is too large and we may split.
So
> updated this one since it may land seperately before the multi url patch. Do
you
> prefer this goes together with multiple url patch?
> > 
> > The Blink OWNERS requested we landed these features together so developers
> could feature detect the new constructor.
> 
> FWIW, I l-g-t-m the other CL. I think...

Thanks a lot! Closing this.

Powered by Google App Engine
This is Rietveld 408576698