Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 2423173002: [PaymentRequest] Persistent 'save card to device' checkbox status (Closed)

Created:
4 years, 2 months ago by gogerald1
Modified:
4 years, 2 months ago
CC:
chromium-reviews, agrieve+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Persistent 'save card to device' checkbox status BUG=656649 Committed: https://crrev.com/638960793467671838cfc0c839f2d01f79328bdf Cr-Commit-Position: refs/heads/master@{#425731}

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -8 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/payments/CardEditor.java View 2 chunks +5 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java View 1 4 chunks +13 lines, -6 lines 0 comments Download

Messages

Total messages: 19 (13 generated)
gogerald1
Hi, PTAL. Note that I've changed the checkbox status to be always persistent and checked ...
4 years, 2 months ago (2016-10-17 17:53:22 UTC) #8
please use gerrit instead
lgtm % comment https://codereview.chromium.org/2423173002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java (right): https://codereview.chromium.org/2423173002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java#newcode145 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:145: * @param checkboxPreference The shared preference ...
4 years, 2 months ago (2016-10-17 18:00:23 UTC) #11
gogerald1
https://codereview.chromium.org/2423173002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java File chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java (right): https://codereview.chromium.org/2423173002/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java#newcode145 chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:145: * @param checkboxPreference The shared preference for the checkbox ...
4 years, 2 months ago (2016-10-17 18:04:06 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423173002/40001
4 years, 2 months ago (2016-10-17 18:04:34 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-17 18:40:00 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 18:41:42 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/638960793467671838cfc0c839f2d01f79328bdf
Cr-Commit-Position: refs/heads/master@{#425731}

Powered by Google App Engine
This is Rietveld 408576698