[PaymentRequest] Persistent 'save card to device' checkbox status

Persistent 'save card to device' checkbox status

BUG=656649
Committed: https://crrev.com/638960793467671838cfc0c839f2d01f79328bdf
Cr-Commit-Position: refs/heads/master@{#425731}

[gogerald1, 2016-10-17 16:53:28]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 16:53:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-17 17:26:56]

The CQ bit was checked by gogerald@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 17:27:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[gogerald1, 2016-10-17 17:40:11]

Patchset #1 (id:1) has been deleted

[gogerald1, 2016-10-17 17:46:37]

Description was changed from

==========
persistent save card to device preference

BUG=
==========

to

==========
Persistent 'save card to device' checkbox status

BUG=656649
==========

[gogerald1, 2016-10-17 17:53:21]

gogerald@chromium.org changed reviewers:
+ rouslan@chromium.org

[gogerald1, 2016-10-17 17:53:22]

Hi, PTAL. Note that I've changed the checkbox status to be always persistent and
checked by default for simplicity since EditorFieldModel.createCheckbox is only
used by CardEditor for now and I don't see any future reason to not persist it
and not checked by default.

[commit-bot: I haz the power, 2016-10-17 17:57:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 17:57:50]

Dry run: This issue passed the CQ dry run.

[please use gerrit instead, 2016-10-17 18:00:23]

lgtm % comment

https://codereview.chromium.org/2423173002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2423173002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:145:
* @param checkboxPreference The shared preference for the checkbox status.
This file alsigns parameter comments. See lines 123-126 for example. Can you
align these please?

[gogerald1, 2016-10-17 18:04:06]

https://codereview.chromium.org/2423173002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java
(right):

https://codereview.chromium.org/2423173002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/payments/ui/EditorFieldModel.java:145:
* @param checkboxPreference The shared preference for the checkbox status.
On 2016/10/17 18:00:23, rouslan (slow 10.10-10.17) wrote:
> This file alsigns parameter comments. See lines 123-126 for example. Can you
> align these please?

Done.

[gogerald1, 2016-10-17 18:04:14]

The CQ bit was checked by gogerald@chromium.org

[gogerald1, 2016-10-17 18:04:14]

The patchset sent to the CQ was uploaded after l-g-t-m from rouslan@chromium.org
Link to the patchset: https://codereview.chromium.org/2423173002/#ps40001
(title: "address comments")

[commit-bot: I haz the power, 2016-10-17 18:04:34]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 18:39:56]

Description was changed from

==========
Persistent 'save card to device' checkbox status

BUG=656649
==========

to

==========
Persistent 'save card to device' checkbox status

BUG=656649
==========

[commit-bot: I haz the power, 2016-10-17 18:40:00]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-17 18:41:40]

Description was changed from

==========
Persistent 'save card to device' checkbox status

BUG=656649
==========

to

==========
Persistent 'save card to device' checkbox status

BUG=656649

Committed: https://crrev.com/638960793467671838cfc0c839f2d01f79328bdf
Cr-Commit-Position: refs/heads/master@{#425731}
==========

[commit-bot: I haz the power, 2016-10-17 18:41:42]

Patchset 2 (id:??) landed as
https://crrev.com/638960793467671838cfc0c839f2d01f79328bdf
Cr-Commit-Position: refs/heads/master@{#425731}