Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(841)

Unified Diff: cc/trees/layer_tree_host_impl.h

Issue 2423143002: Scrollbar fade animation broken on Android regression resolved. (Closed)
Patch Set: scroll variables cached before reseting, and restored in scrollBegin with inertial phase. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl.cc » ('j') | cc/trees/layer_tree_host_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/trees/layer_tree_host_impl.h
diff --git a/cc/trees/layer_tree_host_impl.h b/cc/trees/layer_tree_host_impl.h
index ccbd9e7393ee42373e8fea65dfebf6b39727e481..2c922b8f6de449cd6b3724d623c7c4a5870b40a2 100644
--- a/cc/trees/layer_tree_host_impl.h
+++ b/cc/trees/layer_tree_host_impl.h
@@ -697,6 +697,13 @@ class CC_EXPORT LayerTreeHostImpl
void SetCompositorContextVisibility(bool is_visible);
void SetWorkerContextVisibility(bool is_visible);
+ // Cache & restore variables that get reset in ClearCurrentlyScrollingLayer.
+ // This is used to restore the variables' values in a scrollBegin event
+ // that is in inertial phase (a fling) to lach the event to its corresponding
tdresser 2016/10/19 15:28:04 lach -> latch.
sahel 2016/10/25 15:34:14 Done.
+ // scroll.
tdresser 2016/10/19 15:28:04 scroll -> scroller.
sahel 2016/10/25 15:34:14 Done.
+ void CacheScrollingVariablesState();
tdresser 2016/10/19 15:28:04 Can we come up with a more specific name than "Scr
sahel 2016/10/25 15:34:14 You are right, but I couldn't come up with a bette
bokan 2016/10/25 17:29:21 How about CacheScrollStateForFling (FlingContinuat
sahel 2016/10/26 14:11:43 Done.
+ void RestoreCachedScrollingVariablesState();
+
using UIResourceMap = std::unordered_map<UIResourceId, UIResourceData>;
UIResourceMap ui_resource_map_;
« no previous file with comments | « no previous file | cc/trees/layer_tree_host_impl.cc » ('j') | cc/trees/layer_tree_host_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698