tools/skp/webpages_playback.py - Issue 2423093002: RecreateSKPs: Fix GoogleStorageDataStore.delete_path

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/skp/webpages_playback.py

Issue 2423093002: RecreateSKPs: Fix GoogleStorageDataStore.delete_path (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/skp/webpages_playback.py

diff --git a/tools/skp/webpages_playback.py b/tools/skp/webpages_playback.py

index 1320a8614c5a63065a11cb67147d887a572874c4..5af23b2c71daa00b68acdc07f1d2d8506c6f6e0f 100644

--- a/tools/skp/webpages_playback.py

+++ b/tools/skp/webpages_playback.py

@@ -485,7 +485,7 @@ class GoogleStorageDataStore(DataStore):

return True

def delete_path(self, path):

- subprocess.check_call(['gsutil', 'rm', '-r', path])

+ subprocess.check_call(['gsutil', 'rm', '-r', '/'.join(self._url, path)])

rmistry 2016/10/17 11:39:40 /'.join(self._url, path) should not work because j

borenet 2016/10/17 11:49:32 Whoops, fixed.

def download_file(self, name, local_path):

subprocess.check_call([

« no previous file with comments | « no previous file | no next file » | no next file with comments »