RecreateSKPs: Fix GoogleStorageDataStore.delete_path

RecreateSKPs: Fix GoogleStorageDataStore.delete_path

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002

Committed: https://skia.googlesource.com/skia/+/7787463668dc14e5e7dd37b836f038a5dd17b28f

[borenet2, 2016-10-17 11:36:44]

Description was changed from

==========
RecreateSKPs: Fix GoogleStorageDataStore.delete_path

BUG=skia:5843
==========

to

==========
RecreateSKPs: Fix GoogleStorageDataStore.delete_path

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002
==========

[borenet, 2016-10-17 11:36:52]

borenet@google.com changed reviewers:
+ borenet@google.com, rmistry@google.com

[borenet, 2016-10-17 11:37:09]

Description was changed from

==========
RecreateSKPs: Fix GoogleStorageDataStore.delete_path

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002
==========

to

==========
RecreateSKPs: Fix GoogleStorageDataStore.delete_path

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002
==========

[rmistry, 2016-10-17 11:39:40]

https://codereview.chromium.org/2423093002/diff/1/tools/skp/webpages_playback.py
File tools/skp/webpages_playback.py (right):

https://codereview.chromium.org/2423093002/diff/1/tools/skp/webpages_playback...
tools/skp/webpages_playback.py:488: subprocess.check_call(['gsutil', 'rm', '-r',
'/'.join(self._url, path)])
/'.join(self._url, path) should not work because join takes in one argument?
posixpath.join(self._url, path) should work though.

[borenet, 2016-10-17 11:49:32]

https://codereview.chromium.org/2423093002/diff/1/tools/skp/webpages_playback.py
File tools/skp/webpages_playback.py (right):

https://codereview.chromium.org/2423093002/diff/1/tools/skp/webpages_playback...
tools/skp/webpages_playback.py:488: subprocess.check_call(['gsutil', 'rm', '-r',
'/'.join(self._url, path)])
On 2016/10/17 11:39:40, rmistry wrote:
> /'.join(self._url, path) should not work because join takes in one argument?
> posixpath.join(self._url, path) should work though.

Whoops, fixed.

[rmistry, 2016-10-17 11:50:20]

lgtm

[borenet, 2016-10-17 11:51:11]

The CQ bit was checked by borenet@google.com

[commit-bot: I haz the power, 2016-10-17 11:51:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 12:12:13]

Description was changed from

==========
RecreateSKPs: Fix GoogleStorageDataStore.delete_path

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002
==========

to

==========
RecreateSKPs: Fix GoogleStorageDataStore.delete_path

BUG=skia:5843
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2423093002

Committed:
https://skia.googlesource.com/skia/+/7787463668dc14e5e7dd37b836f038a5dd17b28f
==========

[commit-bot: I haz the power, 2016-10-17 12:12:13]

Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/7787463668dc14e5e7dd37b836f038a5dd17b28f