scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json - Issue 2423083002: V8: Add valgrind deps to linux64 bots

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json

Issue 2423083002: V8: Add valgrind deps to linux64 bots (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json ('k') | scripts/slave/recipes/v8.expected/full_tryserver_v8_v8_linux64_rel_ng.json » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json

diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json

index 16b6cfa888d7b7401aea5ebd8645908d08db50f6..418a719e7da0f87462a803b27591720c9e76f5fc 100644

--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json

+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder_with_gn.json

@@ -5,7 +5,7 @@

"-u",

"RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",

"--spec",

- "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'v8', 'url': 'https://chromium.googlesource.com/v8/v8'}]",

+ "cache_dir = '[GIT_CACHE]'\nsolutions = [{'custom_deps': {'v8/third_party/valgrind': 'https://chromium.googlesource.com/chromium/deps/valgrind/binaries'}, 'deps_file': '.DEPS.git', 'managed': True, 'name': 'v8', 'url': 'https://chromium.googlesource.com/v8/v8'}]",

"--patch_root",

"v8",

"--revision_mapping_file",