src/interpreter/bytecode-array-builder.h - Issue 2423053002: Install the 'name' property in classes at runtime

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/interpreter/bytecode-array-builder.h

Issue 2423053002: Install the 'name' property in classes at runtime (Closed)

Patch Set: Move computed property names check to parser and runtime function Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/interpreter/bytecode-array-builder.h

diff --git a/src/interpreter/bytecode-array-builder.h b/src/interpreter/bytecode-array-builder.h

index 12cb6a5bcee5dcba3620a0a2129b527afddc7185..e8f5113c6b8938e84b9107fa2b845eada112dd8a 100644

--- a/src/interpreter/bytecode-array-builder.h

+++ b/src/interpreter/bytecode-array-builder.h

@@ -81,6 +81,9 @@ class V8_EXPORT_PRIVATE BytecodeArrayBuilder final

BytecodeArrayBuilder& LoadTheHole();

BytecodeArrayBuilder& LoadTrue();

BytecodeArrayBuilder& LoadFalse();

+ BytecodeArrayBuilder& LoadBoolean(bool is_true) {

Henrique Ferreiro 2016/11/29 11:01:26 I have added this helper.

rmcilroy 2016/11/29 13:05:23 Acknowledged.

+ return is_true ? LoadTrue() : LoadFalse();

+ }

// Global loads to the accumulator and stores from the accumulator.

BytecodeArrayBuilder& LoadGlobal(int feedback_slot, TypeofMode typeof_mode);