Install the 'name' property in classes at runtime

src/compiler/ast-graph-builder.cc

 // Copyright 2014 the V8 project authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "src/compiler/ast-graph-builder.h"
 
 #include "src/ast/compile-time-value.h"
 #include "src/ast/scopes.h"
 #include "src/compilation-info.h"
 #include "src/compiler.h"
@@ skipping 1607 matching lines @@
   for (int i = 0; i < expr->properties()->length(); i++) {
     ClassLiteral::Property* property = expr->properties()->at(i);
     environment()->Push(environment()->Peek(property->is_static() ? 1 : 0));
 
     VisitForValue(property->key());
     Node* name = BuildToName(environment()->Pop(), expr->GetIdForProperty(i));
     environment()->Push(name);
 
     // The static prototype property is read only. We handle the non computed
     // property name case in the parser. Since this is the only case where we
-    // need to check for an own read only property we special case this so we do
-    // not need to do this for every property.
+    // need to check for an own read only property we special case this so we
+    // do not need to do this for every property.
     if (property->is_static() && property->is_computed_name()) {
       Node* check = BuildThrowIfStaticPrototype(environment()->Pop(),
                                                 expr->GetIdForProperty(i));
       environment()->Push(check);
     }
 
     VisitForValue(property->value());
     Node* value = environment()->Pop();
     Node* key = environment()->Pop();
     Node* receiver = environment()->Pop();
@@ skipping 25 matching lines @@
         NewNode(op, receiver, key, value, attr);
         break;
       }
       case ClassLiteral::Property::FIELD: {
         UNREACHABLE();
         break;
       }
     }
   }
 
+  prototype = environment()->Pop();
+
+  // Install a "name" property if missing.
+  if (!expr->has_name_static_property() &&
+      !expr->constructor()->raw_name()->IsEmpty()) {
+    literal = environment()->Pop();
+    const Operator* op =
+        javascript()->CallRuntime(Runtime::kInstallClassNameAccessor);
+    literal =
+        NewNode(op, literal,
+                jsgraph()->BooleanConstant(expr->has_static_computed_names()));

[Toon Verwaest, 2016/11/29 12:27:47]

The standard way is to call a different runtime function rather than passing in
a boolean. You can make the C++ side share code obviously.

+    PrepareFrameState(literal, BailoutId::None());
+    environment()->Push(literal);
+  }
+
   // Set the constructor to have fast properties.
-  prototype = environment()->Pop();
   literal = environment()->Pop();
   const Operator* op = javascript()->CallRuntime(Runtime::kToFastProperties);
   literal = NewNode(op, literal);
 
   // Assign to class variable.
   if (expr->class_variable_proxy() != nullptr) {
     Variable* var = expr->class_variable_proxy()->var();
     VectorSlotPair feedback = CreateVectorSlotPair(
         expr->NeedsProxySlot() ? expr->ProxySlot()
                                : FeedbackVectorSlot::Invalid());
@@ skipping 2668 matching lines @@
     // Phi does not exist yet, introduce one.
     value = NewPhi(inputs, value, control);
     value->ReplaceInput(inputs - 1, other);
   }
   return value;
 }
 
 }  // namespace compiler
 }  // namespace internal
 }  // namespace v8