[Extensions] Convert some callers of ScriptContext::CallFunction

[Extensions] Convert some callers of ScriptContext::CallFunction

ScriptContext::CallFunction is deprecated (see bug for more info).
Since ModuleSystem::CallModuleFunction calls into CallFunction, add
a safe version of CallModuleFunction and begin converting callers.

BUG=629431
Committed: https://crrev.com/aac3066303f55f1fd63d7dc3e04dde4e15c09d8a
Cr-Commit-Position: refs/heads/master@{#426052}

[Devlin, 2016-10-17 21:45:00]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-17 21:45:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-17 22:58:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-17 22:58:50]

Dry run: This issue passed the CQ dry run.

[Devlin, 2016-10-17 23:00:52]

rdevlin.cronin@chromium.org changed reviewers:
+ lazyboy@chromium.org

[lazyboy, 2016-10-18 01:58:57]

https://codereview.chromium.org/2423043003/diff/1/extensions/renderer/module_...
File extensions/renderer/module_system.cc (right):

https://codereview.chromium.org/2423043003/diff/1/extensions/renderer/module_...
extensions/renderer/module_system.cc:344: CallModuleMethod(module_name,
method_name, args->size(), args->data());
here and below: Did you mean CallModuleMethodSafe?

[Devlin, 2016-10-18 16:41:29]

Patchset #2 (id:20001) has been deleted

[Devlin, 2016-10-18 16:41:35]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 16:41:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:42:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:42:20]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Devlin, 2016-10-18 19:13:50]

https://codereview.chromium.org/2423043003/diff/1/extensions/renderer/module_...
File extensions/renderer/module_system.cc (right):

https://codereview.chromium.org/2423043003/diff/1/extensions/renderer/module_...
extensions/renderer/module_system.cc:344: CallModuleMethod(module_name,
method_name, args->size(), args->data());
On 2016/10/18 01:58:57, lazyboy wrote:
> here and below: Did you mean CallModuleMethodSafe?

D'oh.  Here and above, yeah, absolutely did.  Thanks for catching this!

[lazyboy, 2016-10-18 19:28:09]

lgtm

[Devlin, 2016-10-18 20:18:23]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2016-10-18 20:18:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 21:28:12]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-10-21 13:03:19]

Description was changed from

==========
[Extensions] Convert some callers of ScriptContext::CallFunction

ScriptContext::CallFunction is deprecated (see bug for more info).
Since ModuleSystem::CallModuleFunction calls into CallFunction, add
a safe version of CallModuleFunction and begin converting callers.

BUG=629431
==========

to

==========
[Extensions] Convert some callers of ScriptContext::CallFunction

ScriptContext::CallFunction is deprecated (see bug for more info).
Since ModuleSystem::CallModuleFunction calls into CallFunction, add
a safe version of CallModuleFunction and begin converting callers.

BUG=629431

Committed: https://crrev.com/aac3066303f55f1fd63d7dc3e04dde4e15c09d8a
Cr-Commit-Position: refs/heads/master@{#426052}
==========

[commit-bot: I haz the power, 2016-10-21 13:03:20]

Patchset 2 (id:??) landed as
https://crrev.com/aac3066303f55f1fd63d7dc3e04dde4e15c09d8a
Cr-Commit-Position: refs/heads/master@{#426052}