Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1068)

Issue 2423043003: [Extensions] Convert some callers of ScriptContext::CallFunction (Closed)

Created:
4 years, 2 months ago by Devlin
Modified:
4 years, 2 months ago
Reviewers:
lazyboy
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Extensions] Convert some callers of ScriptContext::CallFunction ScriptContext::CallFunction is deprecated (see bug for more info). Since ModuleSystem::CallModuleFunction calls into CallFunction, add a safe version of CallModuleFunction and begin converting callers. BUG=629431 Committed: https://crrev.com/aac3066303f55f1fd63d7dc3e04dde4e15c09d8a Cr-Commit-Position: refs/heads/master@{#426052}

Patch Set 1 #

Total comments: 2

Patch Set 2 : d'oh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+108 lines, -42 lines) Patch
M extensions/renderer/extension_helper.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M extensions/renderer/json_schema_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M extensions/renderer/module_system.h View 3 chunks +20 lines, -2 lines 0 comments Download
M extensions/renderer/module_system.cc View 1 3 chunks +75 lines, -28 lines 0 comments Download
M extensions/renderer/utils_unittest.cc View 1 chunk +10 lines, -9 lines 0 comments Download

Messages

Total messages: 19 (12 generated)
Devlin
4 years, 2 months ago (2016-10-17 23:00:53 UTC) #6
lazyboy
https://codereview.chromium.org/2423043003/diff/1/extensions/renderer/module_system.cc File extensions/renderer/module_system.cc (right): https://codereview.chromium.org/2423043003/diff/1/extensions/renderer/module_system.cc#newcode344 extensions/renderer/module_system.cc:344: CallModuleMethod(module_name, method_name, args->size(), args->data()); here and below: Did you ...
4 years, 2 months ago (2016-10-18 01:58:57 UTC) #7
Devlin
https://codereview.chromium.org/2423043003/diff/1/extensions/renderer/module_system.cc File extensions/renderer/module_system.cc (right): https://codereview.chromium.org/2423043003/diff/1/extensions/renderer/module_system.cc#newcode344 extensions/renderer/module_system.cc:344: CallModuleMethod(module_name, method_name, args->size(), args->data()); On 2016/10/18 01:58:57, lazyboy wrote: ...
4 years, 2 months ago (2016-10-18 19:13:50 UTC) #13
lazyboy
lgtm
4 years, 2 months ago (2016-10-18 19:28:09 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2423043003/40001
4 years, 2 months ago (2016-10-18 20:18:55 UTC) #16
commit-bot: I haz the power
Committed patchset #2 (id:40001)
4 years, 2 months ago (2016-10-18 21:28:12 UTC) #17
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:03:20 UTC) #19
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/aac3066303f55f1fd63d7dc3e04dde4e15c09d8a
Cr-Commit-Position: refs/heads/master@{#426052}

Powered by Google App Engine
This is Rietveld 408576698