Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issue 242303003: Cleanup: Simplify enable_plugin gyp flag and remove an obsolete TODO. (Closed)

Created:
6 years, 8 months ago by Lei Zhang
Modified:
6 years, 8 months ago
Reviewers:
Nico, nilesh
CC:
chromium-reviews
Visibility:
Public.

Description

Cleanup: Simplify enable_plugin gyp flag and remove an obsolete TODO. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=265211

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -6 lines) Patch
M build/common.gypi View 3 chunks +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
Lei Zhang
6 years, 8 months ago (2014-04-18 06:50:13 UTC) #1
nilesh
On 2014/04/18 06:50:13, Lei Zhang wrote: LGTM
6 years, 8 months ago (2014-04-18 13:42:01 UTC) #2
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-22 01:56:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/242303003/20001
6 years, 8 months ago (2014-04-22 01:57:08 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-22 02:58:24 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on win_chromium_x64_rel
6 years, 8 months ago (2014-04-22 02:58:24 UTC) #6
Lei Zhang
The CQ bit was checked by thestig@chromium.org
6 years, 8 months ago (2014-04-22 03:11:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thestig@chromium.org/242303003/20001
6 years, 8 months ago (2014-04-22 03:11:29 UTC) #8
Nico
lgtm
6 years, 8 months ago (2014-04-22 04:49:18 UTC) #9
commit-bot: I haz the power
6 years, 8 months ago (2014-04-22 08:29:15 UTC) #10
Message was sent while issue was closed.
Change committed as 265211

Powered by Google App Engine
This is Rietveld 408576698