Add implementation for Ad Networks Database

Add implementation for Ad Networks Database

This adds the structure of the database of ad networks, but does not yet add the
file of hashes. That will come in a separate path, likely dcommitted (since
rietveld + binary data = flaky).

BUG=357204
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267415

[Devlin, 2014-04-18 00:21:41]

Adrienne, please take a look. :)

[Devlin, 2014-04-22 23:01:51]

friendly ping? :)

[felt, 2014-04-23 03:01:35]

just a few small comments!

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/activity_log/ad_injection_browsertest.cc (right):

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_injection_browsertest.cc:95: private:
Is there any reason why the browsertest has different public/private than the
parent class?

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/activity_log/ad_network_database.cc (right):

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_network_database.cc:70: (size -
kChecksumHashSize) % kUrlHashSize != 0) {
should this be a DCHECK?

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_network_database.cc:76: // other
separations.
how are the list entries (the hashes) separated?

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_network_database.cc:83: // If the
checksum doesn't match, abort.
should this also be a DCHECK?

[Devlin, 2014-04-23 18:16:54]

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/activity_log/ad_injection_browsertest.cc (right):

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_injection_browsertest.cc:95: private:
On 2014/04/23 03:01:36, felt wrote:
> Is there any reason why the browsertest has different public/private than the
> parent class?

Yeah, it's a C++ trick that we commonly do in order to make sure that the only
time these methods are called is through the original implementation.  You can
see it frequently with classes implementing observers, so that only the
notifying class calls them.

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/activity_log/ad_network_database.cc (right):

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_network_database.cc:70: (size -
kChecksumHashSize) % kUrlHashSize != 0) {
On 2014/04/23 03:01:36, felt wrote:
> should this be a DCHECK?

Hmm... good question.  If it were a normal file, then no, because corruption
happens.  But since it's a binary resource baked in, is that possible?  Perhaps
not.  Let's make it a DCHECK, and, if we get tons of crashes, we'll know
something's up. :)

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_network_database.cc:76: // other
separations.
On 2014/04/23 03:01:36, felt wrote:
> how are the list entries (the hashes) separated?

There's no deliminator between them, because they are all a strict size (as is
the checksum) so we know exactly where in the file they should begin and end,
and just read the 8 bytes at a time.

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_network_database.cc:83: // If the
checksum doesn't match, abort.
On 2014/04/23 03:01:36, felt wrote:
> should this also be a DCHECK?

Done.

[felt, 2014-04-23 20:15:22]

lgtm

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
File chrome/browser/extensions/activity_log/ad_network_database.cc (right):

https://codereview.chromium.org/242303002/diff/40001/chrome/browser/extension...
chrome/browser/extensions/activity_log/ad_network_database.cc:76: // other
separations.
On 2014/04/23 18:16:55, D Cronin wrote:
> On 2014/04/23 03:01:36, felt wrote:
> > how are the list entries (the hashes) separated?
> 
> There's no deliminator between them, because they are all a strict size (as is
> the checksum) so we know exactly where in the file they should begin and end,
> and just read the 8 bytes at a time.

ah right

[Devlin, 2014-04-23 21:01:46]

+jhawkins for c/b/browser_resources.grd and c/b/resources/ad_networks.dat
(ad_networks.dat is currently empty, but will later be filled with binary hash
data; anticipated size is ~500 patterns at 8bytes per, or 4kb).

[James Hawkins, 2014-04-23 21:05:00]

lgtm

[Devlin, 2014-04-25 20:51:28]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-04-25 22:04:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/242303002/...

[commit-bot: I haz the power, 2014-04-25 23:13:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:13:52]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_x64_rel

[Devlin, 2014-04-25 23:15:52]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:21:05]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/242303002/...

[commit-bot: I haz the power, 2014-04-25 23:54:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-25 23:54:19]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Devlin, 2014-04-25 23:59:37]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-04-26 00:02:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/242303002/...

[commit-bot: I haz the power, 2014-04-26 03:56:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-04-26 03:56:25]

Try jobs failed on following builders:
  tryserver.chromium on win_chromium_rel

[Devlin, 2014-04-30 22:09:16]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-04-30 22:09:42]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/242303002/...

[commit-bot: I haz the power, 2014-05-01 04:12:17]

Change committed as 267415