Chromium Code Reviews

Unified Diff: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json

Issue 2423013002: Revert of V8: Run simple-leak-check step on release and trybot (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Index: scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
diff --git a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
index f17a132e5727748232f71e12d953d2eb32f3b43f..a8cdc95e4927921e19b9fccf87b4b60203dbddff 100644
--- a/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
+++ b/scripts/slave/recipes/v8.expected/full_client_v8_V8_Linux64___builder.json
@@ -5,7 +5,7 @@
"-u",
"RECIPE_MODULE[depot_tools::bot_update]/resources/bot_update.py",
"--spec",
- "cache_dir = '[GIT_CACHE]'\nsolutions = [{'custom_deps': {'v8/third_party/valgrind': 'https://chromium.googlesource.com/chromium/deps/valgrind/binaries'}, 'deps_file': '.DEPS.git', 'managed': True, 'name': 'v8', 'url': 'https://chromium.googlesource.com/v8/v8'}]",
+ "cache_dir = '[GIT_CACHE]'\nsolutions = [{'deps_file': '.DEPS.git', 'managed': True, 'name': 'v8', 'url': 'https://chromium.googlesource.com/v8/v8'}]",
"--patch_root",
"v8",
"--revision_mapping_file",
@@ -140,7 +140,7 @@
"env": {
"GOMA_SERVICE_ACCOUNT_JSON_FILE": "/creds/service_accounts/service-account-goma-client.json",
"GYP_CHROMIUM_NO_ACTION": "1",
- "GYP_DEFINES": "gomadir='[CACHE]/cipd/goma' has_valgrind=1 target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64",
+ "GYP_DEFINES": "gomadir='[CACHE]/cipd/goma' target_arch=x64 test_isolation_mode=prepare use_goma=1 v8_target_arch=x64",
"GYP_GENERATORS": "ninja",
"PATH": "%(PATH)s:RECIPE_PACKAGE_REPO[depot_tools]"
},
@@ -326,7 +326,6 @@
"[SLAVE_BUILD]/v8/out/Release/mozilla.isolated.gen.json",
"[SLAVE_BUILD]/v8/out/Release/optimize_for_size.isolated.gen.json",
"[SLAVE_BUILD]/v8/out/Release/perf.isolated.gen.json",
- "[SLAVE_BUILD]/v8/out/Release/run-valgrind.isolated.gen.json",
"[SLAVE_BUILD]/v8/out/Release/simdjs.isolated.gen.json",
"[SLAVE_BUILD]/v8/out/Release/test262.isolated.gen.json"
],
@@ -340,7 +339,6 @@
"@@@STEP_LOG_LINE@json.output@ \"mozilla\": \"[dummy hash for mozilla]\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"optimize_for_size\": \"[dummy hash for optimize_for_size]\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"perf\": \"[dummy hash for perf]\", @@@",
- "@@@STEP_LOG_LINE@json.output@ \"run-valgrind\": \"[dummy hash for run-valgrind]\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"simdjs\": \"[dummy hash for simdjs]\", @@@",
"@@@STEP_LOG_LINE@json.output@ \"test262\": \"[dummy hash for test262]\"@@@",
"@@@STEP_LOG_LINE@json.output@}@@@",
@@ -358,7 +356,7 @@
"cp",
"-a",
"public-read",
- "{\"benchmarks\": \"[dummy hash for benchmarks]\", \"bot_default\": \"[dummy hash for bot_default]\", \"check-static-initializers\": \"[dummy hash for check-static-initializers]\", \"mjsunit\": \"[dummy hash for mjsunit]\", \"mozilla\": \"[dummy hash for mozilla]\", \"optimize_for_size\": \"[dummy hash for optimize_for_size]\", \"perf\": \"[dummy hash for perf]\", \"run-valgrind\": \"[dummy hash for run-valgrind]\", \"simdjs\": \"[dummy hash for simdjs]\", \"test262\": \"[dummy hash for test262]\"}",
+ "{\"benchmarks\": \"[dummy hash for benchmarks]\", \"bot_default\": \"[dummy hash for bot_default]\", \"check-static-initializers\": \"[dummy hash for check-static-initializers]\", \"mjsunit\": \"[dummy hash for mjsunit]\", \"mozilla\": \"[dummy hash for mozilla]\", \"optimize_for_size\": \"[dummy hash for optimize_for_size]\", \"perf\": \"[dummy hash for perf]\", \"simdjs\": \"[dummy hash for simdjs]\", \"test262\": \"[dummy hash for test262]\"}",
"gs://chromium-v8/v8-linux64-rel/full-build-linux_f2cbea7e89a45f46819777bb78a1f5bd0241f64c.json"
],
"name": "gsutil upload",
@@ -414,7 +412,6 @@
"mozilla": "[dummy hash for mozilla]",
"optimize_for_size": "[dummy hash for optimize_for_size]",
"perf": "[dummy hash for perf]",
- "run-valgrind": "[dummy hash for run-valgrind]",
"simdjs": "[dummy hash for simdjs]",
"test262": "[dummy hash for test262]"
}
@@ -438,7 +435,6 @@
"mozilla": "[dummy hash for mozilla]",
"optimize_for_size": "[dummy hash for optimize_for_size]",
"perf": "[dummy hash for perf]",
- "run-valgrind": "[dummy hash for run-valgrind]",
"simdjs": "[dummy hash for simdjs]",
"test262": "[dummy hash for test262]"
}
@@ -479,7 +475,6 @@
"mozilla": "[dummy hash for mozilla]",
"optimize_for_size": "[dummy hash for optimize_for_size]",
"perf": "[dummy hash for perf]",
- "run-valgrind": "[dummy hash for run-valgrind]",
"simdjs": "[dummy hash for simdjs]",
"test262": "[dummy hash for test262]"
}

Powered by Google App Engine