components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java - Issue 2422993004: Implement finished reason and exception for BidirectionalStream

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

Issue 2422993004: Implement finished reason and exception for BidirectionalStream (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/cronet/android/java/src/org/chromium/net/impl/CronetBidirectionalStream.java ('K') | « components/cronet/android/java/src/org/chromium/net/impl/CronetUrlRequest.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

diff --git a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

index 100546ef91b1cd36b2c13a9add543b4b14a92ad5..57b4dc4a3641bb956d70cda730aae1070f96e746 100644

--- a/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

+++ b/components/cronet/android/test/javatests/src/org/chromium/net/BidirectionalStreamTest.java

@@ -1200,6 +1200,13 @@ public class BidirectionalStreamTest extends CronetTestBase {

}

assertEquals(expectError, callback.mError != null);

assertEquals(expectError, callback.mOnErrorCalled);

+ if (expectError) {

+ assertNotNull(finishedInfo.getException());

+ assertEquals(RequestFinishedInfo.FAILED, finishedInfo.getFinishedReason());

+ } else {

+ assertNull(finishedInfo.getException());

+ assertEquals(RequestFinishedInfo.CANCELED, finishedInfo.getFinishedReason());

+ }

assertEquals(failureType == FailureType.CANCEL_SYNC

|| failureType == FailureType.CANCEL_ASYNC

|| failureType == FailureType.CANCEL_ASYNC_WITHOUT_PAUSE,