Chromium Code Reviews
DescriptionRevert of Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (patchset #1 id:1 of https://codereview.chromium.org/2419663009/ )
Reason for revert:
Possibly broke Chrome OS:
https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/24655
Original issue's description:
> Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.
>
> We're at ~90% of the blacklist converted, and the rest is hard:
>
> * some of the entries are disabled because of the known bugs in Chromium,
> * skia upstream considered to be not a suitable place for Chrome-specific macros,
> * a few entries point to more than one function (like traceImpl) and a regexp is justified.
>
> BUG=641536
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
>
> Committed: https://crrev.com/fb1595d32aa4bfba0cb83698ef73af61fff6038f
> Cr-Commit-Position: refs/heads/master@{#425607}
TBR=tkent@chromium.org,eae@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=641536
Committed: https://crrev.com/ee27526940dbf16abf1c3f3ee4513e447bbd12b1
Cr-Commit-Position: refs/heads/master@{#425610}
Patch Set 1 #Messages
Total messages: 9 (3 generated)
|