Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 2422973002: Revert of Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (Closed)

Created:
4 years, 2 months ago by krasin1
Modified:
4 years, 2 months ago
Reviewers:
tkent, eae
CC:
ajuma+watch_chromium.org, darktears, apavlov+blink_chromium.org, blink-layers+watch_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, blink-reviews-platform-graphics_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dglazkov+blink, dshwang, drott+blinkwatch_chromium.org, krit, eae+blinkwatch, Eric Willigers, f(malita), jbroman, jchaffraix+rendering, Justin Novosad, kinuko+watch, leviw+renderwatch, pdr+graphicswatchlist_chromium.org, pdr+renderingwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. (patchset #1 id:1 of https://codereview.chromium.org/2419663009/ ) Reason for revert: Possibly broke Chrome OS: https://build.chromium.org/p/chromium.chrome/builders/Google%20Chrome%20ChromeOS/builds/24655 Original issue's description: > Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes. > > We're at ~90% of the blacklist converted, and the rest is hard: > > * some of the entries are disabled because of the known bugs in Chromium, > * skia upstream considered to be not a suitable place for Chrome-specific macros, > * a few entries point to more than one function (like traceImpl) and a regexp is justified. > > BUG=641536 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 > > Committed: https://crrev.com/fb1595d32aa4bfba0cb83698ef73af61fff6038f > Cr-Commit-Position: refs/heads/master@{#425607} TBR=tkent@chromium.org,eae@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=641536 Committed: https://crrev.com/ee27526940dbf16abf1c3f3ee4513e447bbd12b1 Cr-Commit-Position: refs/heads/master@{#425610}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -27 lines) Patch
M third_party/WebKit/Source/core/css/PropertySetCSSStyleDeclaration.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/resolver/StyleResolver.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/PaintInvalidationState.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/FrameTree.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/page/PageAnimator.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintInvalidator.cpp View 3 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/platform/PODIntervalTree.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/ContiguousContainer.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/DEPS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/GraphicsLayer.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/DrawingDisplayItem.h View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintArtifact.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/graphics/paint/PaintController.cpp View 2 chunks +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/web/ChromeClientImpl.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M tools/cfi/blacklist.txt View 1 chunk +33 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
krasin1
Created Revert of Convert a few more CFI blacklist entries into DISABLE_CFI_PERF attributes.
4 years, 2 months ago (2016-10-17 02:26:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422973002/1
4 years, 2 months ago (2016-10-17 02:26:10 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 02:27:16 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ee27526940dbf16abf1c3f3ee4513e447bbd12b1 Cr-Commit-Position: refs/heads/master@{#425610}
4 years, 2 months ago (2016-10-17 02:29:43 UTC) #7
tkent
lgtm
4 years, 2 months ago (2016-10-17 02:32:30 UTC) #8
eae
4 years, 2 months ago (2016-10-17 16:55:13 UTC) #9
Message was sent while issue was closed.
LGTM (post-facto)

Powered by Google App Engine
This is Rietveld 408576698