third_party/WebKit/Source/core/paint/TableSectionPainter.cpp - Issue 2422953003: Repeating header groups should align properly when captions are present

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

Issue 2422953003: Repeating header groups should align properly when captions are present (Closed)

Patch Set: Repeating header groups should align properly when captions are present BUG=652792 CQ_INCLUDE_TRYBO… Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp b/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

index 234a2acccb25d6770620acca4ad06afb9ae118e1..2ccb3acbdc9156eb645adbc2173c22d07a1d940d 100644

--- a/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

@@ -71,6 +71,7 @@ void TableSectionPainter::paintRepeatingHeaderGroup(

LayoutUnit bottomBound =

std::min(LayoutUnit(paintInfo.cullRect().m_rect.maxY()),

paintOffset.y() + table->logicalHeight());

+ paginationOffset.move(0, -m_layoutTableSection.logicalTop().toInt());

mstensho (USE GERRIT) 2016/10/18 17:08:49 LayoutUnit() is cheaper than 0.

while (paginationOffset.y() < bottomBound) {

LayoutPoint nestedOffset =

paginationOffset +