Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Unified Diff: third_party/WebKit/Source/core/paint/TableSectionPainter.cpp

Issue 2422953003: Repeating header groups should align properly when captions are present (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
diff --git a/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp b/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
index 234a2acccb25d6770620acca4ad06afb9ae118e1..e1ed7af6342693f8ace529cb00a8b626c86c2c46 100644
--- a/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
+++ b/third_party/WebKit/Source/core/paint/TableSectionPainter.cpp
@@ -4,6 +4,7 @@
#include "core/paint/TableSectionPainter.h"
+#include "core/layout/LayoutTableCaption.h"
#include "core/layout/LayoutTableCell.h"
#include "core/layout/LayoutTableCol.h"
#include "core/layout/LayoutTableRow.h"
@@ -71,6 +72,8 @@ void TableSectionPainter::paintRepeatingHeaderGroup(
LayoutUnit bottomBound =
std::min(LayoutUnit(paintInfo.cullRect().m_rect.maxY()),
paintOffset.y() + table->logicalHeight());
+ if (table->topCaption())
+ paginationOffset.move(0, -table->topCaption()->logicalHeight().toInt());
mstensho (USE GERRIT) 2016/10/17 19:21:13 So, it's possible to have as many top captions as
rhogan 2016/10/18 16:02:46 Indeed, thanks - updated!
while (paginationOffset.y() < bottomBound) {
LayoutPoint nestedOffset =
paginationOffset +

Powered by Google App Engine
This is Rietveld 408576698