Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: content/browser/devtools/service_worker_devtools_manager.cc

Issue 2422923002: Reduce usage of FOR_EACH_OBSERVER macro in content/browser (Closed)
Patch Set: skip cases in 2418143004 and 2418373002 Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/devtools/service_worker_devtools_manager.cc
diff --git a/content/browser/devtools/service_worker_devtools_manager.cc b/content/browser/devtools/service_worker_devtools_manager.cc
index e7c76d8e9b6de06897c61211ae4f5dde7a495c5f..5febfff097b14bc3a18ba1e168d9d7e9c93daba5 100644
--- a/content/browser/devtools/service_worker_devtools_manager.cc
+++ b/content/browser/devtools/service_worker_devtools_manager.cc
@@ -89,7 +89,8 @@ bool ServiceWorkerDevToolsManager::WorkerCreated(
new ServiceWorkerDevToolsAgentHost(id, service_worker_id,
is_installed_version);
workers_[id] = host.get();
- FOR_EACH_OBSERVER(Observer, observer_list_, WorkerCreated(host.get()));
+ for (auto& observer : observer_list_)
+ observer.WorkerCreated(host.get());
if (debug_service_worker_on_start_)
host->PauseForDebugOnStart();
return host->IsPausedForDebugOnStart();
@@ -114,8 +115,8 @@ void ServiceWorkerDevToolsManager::WorkerReadyForInspection(
return;
scoped_refptr<ServiceWorkerDevToolsAgentHost> host = it->second;
host->WorkerReadyForInspection();
- FOR_EACH_OBSERVER(Observer, observer_list_,
- WorkerReadyForInspection(host.get()));
+ for (auto& observer : observer_list_)
+ observer.WorkerReadyForInspection(host.get());
// Then bring up UI for the ones not picked by other clients.
if (host->IsPausedForDebugOnStart() && !host->IsAttached())
@@ -131,8 +132,8 @@ void ServiceWorkerDevToolsManager::WorkerVersionInstalled(int worker_process_id,
return;
scoped_refptr<ServiceWorkerDevToolsAgentHost> host = it->second;
host->WorkerVersionInstalled();
- FOR_EACH_OBSERVER(Observer, observer_list_,
- WorkerVersionInstalled(host.get()));
+ for (auto& observer : observer_list_)
+ observer.WorkerVersionInstalled(host.get());
}
void ServiceWorkerDevToolsManager::WorkerVersionDoomed(int worker_process_id,
@@ -144,7 +145,8 @@ void ServiceWorkerDevToolsManager::WorkerVersionDoomed(int worker_process_id,
return;
scoped_refptr<ServiceWorkerDevToolsAgentHost> host = it->second;
host->WorkerVersionDoomed();
- FOR_EACH_OBSERVER(Observer, observer_list_, WorkerVersionDoomed(host.get()));
+ for (auto& observer : observer_list_)
+ observer.WorkerVersionDoomed(host.get());
}
void ServiceWorkerDevToolsManager::WorkerDestroyed(int worker_process_id,
@@ -156,7 +158,8 @@ void ServiceWorkerDevToolsManager::WorkerDestroyed(int worker_process_id,
return;
scoped_refptr<WorkerDevToolsAgentHost> agent_host(it->second);
agent_host->WorkerDestroyed();
- FOR_EACH_OBSERVER(Observer, observer_list_, WorkerDestroyed(it->second));
+ for (auto& observer : observer_list_)
+ observer.WorkerDestroyed(it->second);
}
void ServiceWorkerDevToolsManager::RemoveInspectedWorkerData(WorkerId id) {
« no previous file with comments | « content/browser/compositor/gpu_process_transport_factory.cc ('k') | content/browser/dom_storage/dom_storage_context_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698