Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(667)

Issue 2422873002: Remove usage of FOR_EACH_OBSERVER macro in ui/app_list (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
xiyuan
CC:
chromium-reviews, tfarina, Matt Giuca
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in ui/app_list Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f Cr-Commit-Position: refs/heads/master@{#425746}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+106 lines, -120 lines) Patch
M ui/app_list/app_list_item.cc View 5 chunks +12 lines, -10 lines 0 comments Download
M ui/app_list/app_list_item_list.cc View 7 chunks +16 lines, -23 lines 0 comments Download
M ui/app_list/app_list_model.cc View 11 chunks +30 lines, -39 lines 0 comments Download
M ui/app_list/folder_image.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/app_list/pagination_model.cc View 2 chunks +8 lines, -6 lines 0 comments Download
M ui/app_list/search/history_data.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ui/app_list/search_box_model.cc View 5 chunks +10 lines, -9 lines 0 comments Download
M ui/app_list/search_result.cc View 4 chunks +14 lines, -15 lines 0 comments Download
M ui/app_list/speech_ui_model.cc View 3 chunks +6 lines, -9 lines 0 comments Download
M ui/app_list/views/app_list_view.cc View 1 chunk +4 lines, -3 lines 0 comments Download
M ui/app_list/views/top_icon_animation_view.cc View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 14:04:43 UTC) #4
xiyuan
lgtm
4 years, 2 months ago (2016-10-17 15:48:41 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422873002/1
4 years, 2 months ago (2016-10-17 18:45:49 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-17 19:24:44 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-17 19:27:58 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/741d9665244b69173a34ddc8a6c1ecf5c9dc188f
Cr-Commit-Position: refs/heads/master@{#425746}

Powered by Google App Engine
This is Rietveld 408576698