Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2422853002: Remove usage of FOR_EACH_OBSERVER macro in chromecast (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
alokp
CC:
chromium-reviews, alokp+watch_chromium.org, lcwu+watch_chromium.org, halliwell+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove usage of FOR_EACH_OBSERVER macro in chromecast Observer lists now support range-based for loops. BUG=655021 Committed: https://crrev.com/d54a2ec95d7c59e6ebf65dd07de3e30cba882bd0 Cr-Commit-Position: refs/heads/master@{#425575}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M chromecast/graphics/cast_vsync_settings.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Eric Willigers
4 years, 2 months ago (2016-10-15 13:13:50 UTC) #6
alokp
lgtm
4 years, 2 months ago (2016-10-15 13:30:48 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422853002/1
4 years, 2 months ago (2016-10-15 21:57:04 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-15 22:02:04 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-10-15 22:06:09 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d54a2ec95d7c59e6ebf65dd07de3e30cba882bd0
Cr-Commit-Position: refs/heads/master@{#425575}

Powered by Google App Engine
This is Rietveld 408576698