DevTools: prefix node.js scripts's sourceURL with "file://" to make them a valid url

DevTools: prefix node.js scripts's sourceURL with "file://" to make them a valid url

As of today, Node.js scripts are reported with a file path
as their sourceURL.

File path by itself is not a correct URL. This patch prepends
file:// to the path to make it a proper url.

BUG=none

Committed: https://crrev.com/852dea567434d8a7a9f4bcbfa7fff00c74bac471
Cr-Commit-Position: refs/heads/master@{#426261}

[lushnikov, 2016-10-15 00:36:11]

please, take

[lushnikov, 2016-10-15 00:36:24]

Description was changed from

==========
DevTools: prefix node.js-scripts with a proper file url

This patch makes node.js scripts carry a proper file:// url.
As a result, the patch gets rid of WI.ParsedURL.splitURLIntoPathComponents.

BUG=none
==========

to

==========
DevTools: prefix node.js-scripts with a proper file url

This patch makes node.js scripts carry a proper file:// url.
As a result, the patch gets rid of WI.ParsedURL.splitURLIntoPathComponents.

BUG=none
==========

[lushnikov, 2016-10-15 00:36:24]

lushnikov@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[lushnikov, 2016-10-15 00:36:31]

please, take a look*

[lushnikov, 2016-10-15 00:36:35]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 00:37:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-10-15 00:42:35]

https://codereview.chromium.org/2422803002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right):

https://codereview.chromium.org/2422803002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:478: if
(Runtime.queryParam("v8only") && sourceURL && sourceURL.startsWith("/"))
- In case when Node target is attached from within regular DevTools, this does
not work.
- In case Windows decides to use C:\Documents and Settings\ that also does not
work (it does not start with "/")

So you need to check whether you are talking to Node target. We need target
metainfo available here :(

[lushnikov, 2016-10-15 00:59:03]

thanks

https://codereview.chromium.org/2422803002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right):

https://codereview.chromium.org/2422803002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:478: if
(Runtime.queryParam("v8only") && sourceURL && sourceURL.startsWith("/"))
Handled (1) via the Target.isNodeJS()

We're in a poor position to address (2) - looks like it should be
handled on the node.js side

[lushnikov, 2016-10-15 00:59:09]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-15 00:59:25]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-15 02:17:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-15 02:17:53]

Dry run: This issue passed the CQ dry run.

[lushnikov, 2016-10-15 03:28:02]

Description was changed from

==========
DevTools: prefix node.js-scripts with a proper file url

This patch makes node.js scripts carry a proper file:// url.
As a result, the patch gets rid of WI.ParsedURL.splitURLIntoPathComponents.

BUG=none
==========

to

==========
DevTools: prefix node.js scripts with file:// to make it valid url

This patch makes node.js scripts carry a proper file:// url.
As a result, the patch gets rid of WI.ParsedURL.splitURLIntoPathComponents.

BUG=none
==========

[lushnikov, 2016-10-15 03:30:29]

Description was changed from

==========
DevTools: prefix node.js scripts with file:// to make it valid url

This patch makes node.js scripts carry a proper file:// url.
As a result, the patch gets rid of WI.ParsedURL.splitURLIntoPathComponents.

BUG=none
==========

to

==========
DevTools: prefix node.js scripts with file:// to make it valid url

As of today, Node.js scripts are reported with a file path
as their sourceURL.

File path by itself is not a correct URL. This patch prepends
file:// to the path to make it a proper url.

BUG=none
==========

[lushnikov, 2016-10-15 03:31:09]

Description was changed from

==========
DevTools: prefix node.js scripts with file:// to make it valid url

As of today, Node.js scripts are reported with a file path
as their sourceURL.

File path by itself is not a correct URL. This patch prepends
file:// to the path to make it a proper url.

BUG=none
==========

to

==========
DevTools: prefix node.js scripts's sourceURL with "file://" to make them a valid
url

As of today, Node.js scripts are reported with a file path
as their sourceURL.

File path by itself is not a correct URL. This patch prepends
file:// to the path to make it a proper url.

BUG=none
==========

[dgozman, 2016-10-18 21:46:12]

lgtm

https://codereview.chromium.org/2422803002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js (right):

https://codereview.chromium.org/2422803002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/sdk/DebuggerModel.js:479: sourceURL
= "file://" + sourceURL;
WebInspector.IsolatedFileSystemManager.normalizePath

[lushnikov, 2016-10-19 03:26:49]

renamed WI.IsolatedFileSystemManager.normalizePath to
WI.ParsedURL.platformPathToURL

let me know if you like this name!

[lushnikov, 2016-10-19 03:26:55]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 03:28:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 05:34:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 05:34:56]

Dry run: Exceeded global retry quota

[lushnikov, 2016-10-19 18:27:22]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-10-19 18:27:22]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2422803002/#ps60001
(title: "WI.ParsedURL.platformPathToURL")

[commit-bot: I haz the power, 2016-10-19 18:27:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-19 19:47:52]

Description was changed from

==========
DevTools: prefix node.js scripts's sourceURL with "file://" to make them a valid
url

As of today, Node.js scripts are reported with a file path
as their sourceURL.

File path by itself is not a correct URL. This patch prepends
file:// to the path to make it a proper url.

BUG=none
==========

to

==========
DevTools: prefix node.js scripts's sourceURL with "file://" to make them a valid
url

As of today, Node.js scripts are reported with a file path
as their sourceURL.

File path by itself is not a correct URL. This patch prepends
file:// to the path to make it a proper url.

BUG=none
==========

[commit-bot: I haz the power, 2016-10-19 19:47:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:10:47]

Description was changed from

==========
DevTools: prefix node.js scripts's sourceURL with "file://" to make them a valid
url

As of today, Node.js scripts are reported with a file path
as their sourceURL.

File path by itself is not a correct URL. This patch prepends
file:// to the path to make it a proper url.

BUG=none
==========

to

==========
DevTools: prefix node.js scripts's sourceURL with "file://" to make them a valid
url

As of today, Node.js scripts are reported with a file path
as their sourceURL.

File path by itself is not a correct URL. This patch prepends
file:// to the path to make it a proper url.

BUG=none

Committed: https://crrev.com/852dea567434d8a7a9f4bcbfa7fff00c74bac471
Cr-Commit-Position: refs/heads/master@{#426261}
==========

[commit-bot: I haz the power, 2016-10-21 13:10:48]

Patchset 4 (id:??) landed as
https://crrev.com/852dea567434d8a7a9f4bcbfa7fff00c74bac471
Cr-Commit-Position: refs/heads/master@{#426261}