Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(516)

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 24228003: Upstream ShouldOverrideUrlLoading changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: addressed code review Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
index 1f7bb24a0034e116fcebb96324e3d49744daaf2c..8440c5244ca6b8197026e7613a07d225ca2b2545 100644
--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java
@@ -23,6 +23,7 @@ import android.webkit.SslErrorHandler;
import android.webkit.ValueCallback;
import android.webkit.WebChromeClient;
+import org.chromium.base.ThreadUtils;
import org.chromium.content.browser.ContentVideoView;
import org.chromium.content.browser.ContentVideoViewClient;
import org.chromium.content.browser.ContentVideoViewControls;
@@ -62,8 +63,13 @@ public abstract class AwContentsClient {
}
@Override
- public void didStopLoading(String url) {
- AwContentsClient.this.onPageFinished(url);
+ public void didStopLoading(final String url) {
+ ThreadUtils.postOnUiThread(new Runnable() {
mkosiba (inactive) 2013/10/17 10:27:45 I believe there is no reason to do the post here.
sgurun-gerrit only 2013/12/06 00:17:48 this comment is stale now. On 2013/10/17 10:27:45,
+ @Override
+ public void run() {
+ AwContentsClient.this.onPageFinished(url);
+ }
+ });
}
@Override

Powered by Google App Engine
This is Rietveld 408576698