android_webview/java/src/org/chromium/android_webview/AwContentsClient.java - Issue 24228003: Upstream ShouldOverrideUrlLoading changes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

Issue 24228003: Upstream ShouldOverrideUrlLoading changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: add a forgotten merge reject Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwContents.java ('k') | android_webview/java/src/org/chromium/android_webview/AwContentsClientBridge.java » ('j') | android_webview/native/aw_contents.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

diff --git a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

index 3f2245ca460cd2945ca94bfa13b920ac7dc4f53d..44241d69d59cfdcf8f3783fb120443884e2d5bc1 100644

--- a/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

+++ b/android_webview/java/src/org/chromium/android_webview/AwContentsClient.java

@@ -23,6 +23,7 @@ import android.webkit.SslErrorHandler;

import android.webkit.ValueCallback;

import android.webkit.WebChromeClient;

+import org.chromium.base.ThreadUtils;

import org.chromium.content.browser.ContentVideoView;

import org.chromium.content.browser.ContentVideoViewClient;

import org.chromium.content.browser.ContentVideoViewControls;

@@ -64,8 +65,13 @@ public abstract class AwContentsClient {

}

@Override

- public void didStopLoading(String url) {

- AwContentsClient.this.onPageFinished(url);

+ public void didStopLoading(final String url) {

+ ThreadUtils.postOnUiThread(new Runnable() {

+ @Override

+ public void run() {

+ AwContentsClient.this.onPageFinished(url);

+ }

+ });

}

@Override