Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3997)

Unified Diff: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc

Issue 24228003: Upstream ShouldOverrideUrlLoading changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
diff --git a/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
index 6f4c3659bbae5eb532bdb08edc2c58e276d5c134..24b8dc974c6316e86212e1c32377aa830966b237 100644
--- a/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
+++ b/android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc
@@ -12,7 +12,6 @@
#include "base/memory/scoped_ptr.h"
#include "base/memory/scoped_vector.h"
#include "components/auto_login_parser/auto_login_parser.h"
-#include "components/navigation_interception/intercept_navigation_delegate.h"
#include "content/public/browser/browser_thread.h"
#include "content/public/browser/resource_controller.h"
#include "content/public/browser/resource_dispatcher_host.h"
@@ -26,7 +25,6 @@
using android_webview::AwContentsIoThreadClient;
using content::BrowserThread;
-using navigation_interception::InterceptNavigationDelegate;
namespace {
@@ -222,24 +220,6 @@ void AwResourceDispatcherHostDelegate::RequestBeginning(
throttles->push_back(new IoThreadClientThrottle(
child_id, route_id, request));
-
- bool allow_intercepting =
- // We allow intercepting navigations within subframes, but only if the
- // scheme other than http or https. This is because the embedder
- // can't distinguish main frame and subframe callbacks (which could lead
- // to broken content if the embedder decides to not ignore the main frame
- // navigation, but ignores the subframe navigation).
- // The reason this is supported at all is that certain JavaScript-based
- // frameworks use iframe navigation as a form of communication with the
- // embedder.
- (resource_type == ResourceType::MAIN_FRAME ||
- (resource_type == ResourceType::SUB_FRAME &&
- !request->url().SchemeIs(content::kHttpScheme) &&
- !request->url().SchemeIs(content::kHttpsScheme)));
- if (allow_intercepting) {
- throttles->push_back(InterceptNavigationDelegate::CreateThrottleFor(
- request));
- }
}
void AwResourceDispatcherHostDelegate::DownloadStarting(

Powered by Google App Engine
This is Rietveld 408576698