android_webview/common/render_view_messages.h - Issue 24228003: Upstream ShouldOverrideUrlLoading changes

Side by Side Diff: android_webview/common/render_view_messages.h

Issue 24228003: Upstream ShouldOverrideUrlLoading changes (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: addressed code review Created 7 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('K') | « android_webview/browser/renderer_host/aw_resource_dispatcher_host_delegate.cc ('k') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('j') | android_webview/java/src/org/chromium/android_webview/AwContents.java » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.	1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 // Multiply-included file, no traditional include guard.	5 // Multiply-included file, no traditional include guard.

6 #include "android_webview/common/aw_hit_test_data.h"	6 #include "android_webview/common/aw_hit_test_data.h"

7 #include "content/public/common/common_param_traits.h"	7 #include "content/public/common/common_param_traits.h"

8 #include "ipc/ipc_channel_handle.h"	8 #include "ipc/ipc_channel_handle.h"

9 #include "ipc/ipc_message_macros.h"	9 #include "ipc/ipc_message_macros.h"

10 #include "ipc/ipc_platform_file.h"	10 #include "ipc/ipc_platform_file.h"

(...skipping 81 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
92 IPC_MESSAGE_ROUTED1(AwViewHostMsg_UpdateHitTestData,	92 IPC_MESSAGE_ROUTED1(AwViewHostMsg_UpdateHitTestData,

93 android_webview::AwHitTestData)	93 android_webview::AwHitTestData)

94	94

95 // Sent whenever the page scale factor (as seen by RenderView) is changed.	95 // Sent whenever the page scale factor (as seen by RenderView) is changed.

96 IPC_MESSAGE_ROUTED1(AwViewHostMsg_PageScaleFactorChanged,	96 IPC_MESSAGE_ROUTED1(AwViewHostMsg_PageScaleFactorChanged,

97 float /* page_scale_factor */)	97 float /* page_scale_factor */)

98	98

99 // Sent whenever the contents size (as seen by RenderView) is changed.	99 // Sent whenever the contents size (as seen by RenderView) is changed.

100 IPC_MESSAGE_ROUTED1(AwViewHostMsg_OnContentsSizeChanged,	100 IPC_MESSAGE_ROUTED1(AwViewHostMsg_OnContentsSizeChanged,

101 gfx::Size /* contents_size */)	101 gfx::Size /* contents_size */)

	102

	103 // Sent when there is a top level navigation. Returning true means
	mkosiba (inactive) 2013/10/17 10:27:45 The description is a bit vague. Maybe: "Sent imme The description is a bit vague. Maybe: "Sent immediately before the main frame (top level) navigation is initiated within Blink to allow the browser process to cancel that navigation. This is sent before updating the NavigationController state or creating a URLRequest for the main frame resource." sgurun-gerrit only 2013/12/06 00:17:48 Done. Show quoted text On 2013/10/17 10:27:45, mkosiba wrote: > The description is a bit vague. Maybe: > > "Sent immediately before the main frame (top level) navigation is initiated > within Blink to allow the browser process to cancel that navigation. This is > sent before updating the NavigationController state or creating a URLRequest for > the main frame resource." Done.
	104 // the application will handle this request and so will cancel the

	105 // navigation within Blink. The view id is used to identify the correct

	106 // WebContents. When a pop up is involved, the view id indicates the

	107 // id of the opener view and not the opened one.

	108 IPC_SYNC_MESSAGE_CONTROL2_1(AwViewHostMsg_ShouldOverrideUrlLoading,

	109 int /* view id */,

	110 string16 /* in - url */,

	111 bool /* out - result */)

OLD	NEW