Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(820)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)
Patch Set: Eliminate unnecessary PostTask Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index e7d049c0d22cfd26f8f3ce455df2af10182aee9a..80395687f4c9758d70d55ed12e24bd55be03aff8 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -233,7 +233,6 @@
#if defined(OS_ANDROID)
#include <cpu-features.h>
-#include "content/renderer/android/app_web_message_port_client.h"
#include "content/renderer/java/gin_java_bridge_dispatcher.h"
#include "content/renderer/media/android/media_player_renderer_client_factory.h"
#include "content/renderer/media/android/renderer_media_player_manager.h"
@@ -1256,10 +1255,6 @@ void RenderFrameImpl::Initialize() {
// embedder can call GetWebFrame on any RenderFrame.
GetContentClient()->renderer()->RenderFrameCreated(this);
-#if defined(OS_ANDROID)
- new AppWebMessagePortClient(this);
-#endif
-
RenderThreadImpl* render_thread = RenderThreadImpl::current();
// render_thread may be NULL in tests.
InputHandlerManager* input_handler_manager =
@@ -2213,9 +2208,7 @@ void RenderFrameImpl::OnPostMessageEvent(
// If the message contained MessagePorts, create the corresponding endpoints.
blink::WebMessagePortChannelArray channels =
- WebMessagePortChannelImpl::CreatePorts(
- params.message_ports, params.new_routing_ids,
- base::ThreadTaskRunnerHandle::Get().get());
+ WebMessagePortChannelImpl::CreateFromMessagePorts(params.message_ports);
WebSerializedScriptValue serialized_script_value;
if (params.is_data_raw_string) {
@@ -2244,7 +2237,9 @@ void RenderFrameImpl::OnPostMessageEvent(
WebDOMMessageEvent msg_event(serialized_script_value,
WebString::fromUTF16(params.source_origin),
- source_frame, frame_->document(), channels);
+ source_frame,
+ frame_->document(),
+ std::move(channels));
frame_->dispatchMessageEventWithOriginCheck(target_origin, msg_event);
}

Powered by Google App Engine
This is Rietveld 408576698