Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(658)

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)
Patch Set: Address feedback from yusuf Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
index e22ac3b405e330206b0533c0d1184ea982b97bb7..f4aedde5204a82cbf1b11a878ec900156e9a7f52 100644
--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp
@@ -110,12 +110,12 @@ void ServiceWorkerGlobalScopeProxy::dispatchExtendableMessageEvent(
int eventID,
const WebString& message,
const WebSecurityOrigin& sourceOrigin,
- const WebMessagePortChannelArray& webChannels,
+ WebMessagePortChannelArray webChannels,
const WebServiceWorkerClientInfo& client) {
WebSerializedScriptValue value =
WebSerializedScriptValue::fromString(message);
- MessagePortArray* ports =
- MessagePort::toMessagePortArray(m_workerGlobalScope, webChannels);
+ MessagePortArray* ports = MessagePort::toMessagePortArray(
+ m_workerGlobalScope, std::move(webChannels));
String origin;
if (!sourceOrigin.isUnique())
origin = sourceOrigin.toString();
@@ -136,12 +136,12 @@ void ServiceWorkerGlobalScopeProxy::dispatchExtendableMessageEvent(
int eventID,
const WebString& message,
const WebSecurityOrigin& sourceOrigin,
- const WebMessagePortChannelArray& webChannels,
+ WebMessagePortChannelArray webChannels,
std::unique_ptr<WebServiceWorker::Handle> handle) {
WebSerializedScriptValue value =
WebSerializedScriptValue::fromString(message);
- MessagePortArray* ports =
- MessagePort::toMessagePortArray(m_workerGlobalScope, webChannels);
+ MessagePortArray* ports = MessagePort::toMessagePortArray(
+ m_workerGlobalScope, std::move(webChannels));
String origin;
if (!sourceOrigin.isUnique())
origin = sourceOrigin.toString();

Powered by Google App Engine
This is Rietveld 408576698