third_party/WebKit/Source/core/frame/DOMWindow.cpp - Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/frame/DOMWindow.cpp

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)

Patch Set: Address feedback from yusuf Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/frame/DOMWindow.cpp

diff --git a/third_party/WebKit/Source/core/frame/DOMWindow.cpp b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

index 4c1849a63384dd6936e9b873ed61a55bad8d9af9..88afef007b345e77e54a1be2512949fb52fa9d02 100644

--- a/third_party/WebKit/Source/core/frame/DOMWindow.cpp

+++ b/third_party/WebKit/Source/core/frame/DOMWindow.cpp

@@ -184,9 +184,8 @@ void DOMWindow::postMessage(PassRefPtr<SerializedScriptValue> message,

}

- std::unique_ptr<MessagePortChannelArray> channels =

- MessagePort::disentanglePorts(getExecutionContext(), ports,

- exceptionState);

+ MessagePortChannelArray channels = MessagePort::disentanglePorts(

+ getExecutionContext(), ports, exceptionState);

if (exceptionState.hadException())

return;