third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp - Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)

Patch Set: Remove unnecessary histogram Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/bindings/core/v8/serialization/SerializedScriptValueFuzzer.cpp ('k') | third_party/WebKit/Source/core/dom/MessagePort.h » ('j') | third_party/WebKit/Source/core/dom/MessagePort.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

diff --git a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

index 4da53c0411eec16f40ae1f445ba163196f02d512..7772fb248d2395426f16f18e379a5e8665e7bedf 100644

--- a/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

+++ b/third_party/WebKit/Source/bindings/core/v8/serialization/V8ScriptValueSerializerTest.cpp

@@ -260,7 +260,6 @@ class WebMessagePortChannelImpl final : public WebMessagePortChannel {

public:

// WebMessagePortChannel

void setClient(WebMessagePortChannelClient* client) override {}

- void destroy() override { delete this; }

void postMessage(const WebString&, WebMessagePortChannelArray*) {

NOTIMPLEMENTED();

}