Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2683)

Unified Diff: content/renderer/service_worker/service_worker_context_client.cc

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)
Patch Set: Remove unnecessary histogram Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.cc
diff --git a/content/renderer/service_worker/service_worker_context_client.cc b/content/renderer/service_worker/service_worker_context_client.cc
index b07de5d43b1aee04581ad908938827603fc102c3..8b0eab21317718371ecaccedac7ddf7b39b00c15 100644
--- a/content/renderer/service_worker/service_worker_context_client.cc
+++ b/content/renderer/service_worker/service_worker_context_client.cc
@@ -33,7 +33,6 @@
#include "content/child/web_url_loader_impl.h"
#include "content/child/webmessageportchannel_impl.h"
#include "content/common/devtools_messages.h"
-#include "content/common/message_port_messages.h"
#include "content/common/service_worker/embedded_worker_messages.h"
#include "content/common/service_worker/service_worker_event_dispatcher.mojom.h"
#include "content/common/service_worker/service_worker_messages.h"
@@ -135,7 +134,7 @@ void SendPostMessageToClientOnMainThread(
std::unique_ptr<blink::WebMessagePortChannelArray> channels) {
sender->Send(new ServiceWorkerHostMsg_PostMessageToClient(
routing_id, uuid, message,
- WebMessagePortChannelImpl::ExtractMessagePortIDs(std::move(channels))));
+ WebMessagePortChannelImpl::ExtractMessagePorts(std::move(channels))));
}
blink::WebURLRequest::FetchRequestMode GetBlinkFetchRequestMode(
@@ -920,15 +919,14 @@ void ServiceWorkerContextClient::DispatchExtendableMessageEvent(
base::MakeUnique<DispatchExtendableMessageEventCallback>(callback));
blink::WebMessagePortChannelArray ports =
- WebMessagePortChannelImpl::CreatePorts(event->message_ports,
- event->new_routing_ids,
- main_thread_task_runner_);
+ WebMessagePortChannelImpl::CreateFromMessagePipeHandles(
+ std::move(event->message_ports));
if (event->source.client_info.IsValid()) {
blink::WebServiceWorkerClientInfo web_client =
ToWebServiceWorkerClientInfo(event->source.client_info);
proxy_->dispatchExtendableMessageEvent(
request_id, blink::WebString::fromUTF16(event->message),
- event->source_origin, ports, web_client);
+ event->source_origin, std::move(ports), web_client);
return;
}
@@ -943,7 +941,8 @@ void ServiceWorkerContextClient::DispatchExtendableMessageEvent(
dispatcher->GetOrCreateServiceWorker(std::move(handle));
proxy_->dispatchExtendableMessageEvent(
request_id, blink::WebString::fromUTF16(event->message),
- event->source_origin, ports, WebServiceWorkerImpl::CreateHandle(worker));
+ event->source_origin, std::move(ports),
+ WebServiceWorkerImpl::CreateHandle(worker));
}
void ServiceWorkerContextClient::OnInstallEvent(int request_id) {

Powered by Google App Engine
This is Rietveld 408576698