Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Unified Diff: content/browser/android/app_web_message_port_service_impl.h

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)
Patch Set: Rebase Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/android/app_web_message_port_service_impl.h
diff --git a/content/browser/android/app_web_message_port_service_impl.h b/content/browser/android/app_web_message_port_service_impl.h
index 84c72eafcd05a4911478805051de4d41337467ee..a44f8b72808e853c1c4e8d7b6b00f85c705cadbb 100644
--- a/content/browser/android/app_web_message_port_service_impl.h
+++ b/content/browser/android/app_web_message_port_service_impl.h
@@ -15,7 +15,6 @@
#include "content/public/browser/android/app_web_message_port_service.h"
namespace content {
-class AppWebMessagePortMessageFilter;
// This class is the native peer of AppWebMessagePortService.java.
// Please see the java class for an explanation of use, ownership and lifetime.
@@ -36,52 +35,11 @@ class AppWebMessagePortServiceImpl : public AppWebMessagePortService {
void CreateMessageChannel(JNIEnv* env,
const base::android::JavaRef<jobjectArray>& ports,
WebContents* web_contents) override;
- void CleanupPort(int message_port_id) override;
-
- // Methods called from Java.
- void PostAppToWebMessage(
- JNIEnv* env,
- const base::android::JavaParamRef<jobject>& object,
- int sender_id,
- const base::android::JavaParamRef<jstring>& message,
- const base::android::JavaParamRef<jintArray>& sent_ports);
- void ClosePort(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& object,
- int message_port_id);
- void ReleaseMessages(JNIEnv* env,
- const base::android::JavaParamRef<jobject>& object,
- int message_port_id);
-
- void OnMessagePortMessageFilterClosing(
- AppWebMessagePortMessageFilter* filter);
-
- // AppWebMessagePortServiceImpl specific calls
- void OnConvertedWebToAppMessage(
Yusuf 2017/01/26 22:53:54 does this mean we should also be cleaning up app_w
- int message_port_id,
- const base::ListValue& message,
- const std::vector<int>& sent_message_port_ids);
- void RemoveSentPorts(const std::vector<int>& sent_ports);
private:
friend struct base::DefaultSingletonTraits<AppWebMessagePortServiceImpl>;
- void PostAppToWebMessageOnIOThread(int sender_id,
- base::string16* message,
- std::vector<int>* sent_ports);
- void CreateMessageChannelOnIOThread(
- scoped_refptr<AppWebMessagePortMessageFilter> filter,
- int* port1,
- int* port2);
- void OnMessageChannelCreated(
- const base::android::JavaRef<jobjectArray>& ports,
- int* port1,
- int* port2);
- void AddPort(int message_port_id, AppWebMessagePortMessageFilter* filter);
- void PostClosePortMessage(int message_port_id);
-
JavaObjectWeakGlobalRef java_ref_;
- typedef std::map<int, AppWebMessagePortMessageFilter*> MessagePorts;
- MessagePorts ports_; // Access on IO thread
DISALLOW_COPY_AND_ASSIGN(AppWebMessagePortServiceImpl);
};

Powered by Google App Engine
This is Rietveld 408576698