third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp - Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)

Patch Set: Add missing ScopedAsyncTaskScheduler instance for the new unit tests; required by a recent change t… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.h ('k') | third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

index 8fd4855a4a6b35b0bba560b0ae0f4ab832afefd3..907f36b3359f1be03df5a82bed4ad8f76a94e489 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeClientImpl.cpp

@@ -159,8 +159,8 @@ void ServiceWorkerGlobalScopeClientImpl::didHandlePaymentRequestEvent(

void ServiceWorkerGlobalScopeClientImpl::postMessageToClient(

const WebString& clientUUID,

const WebString& message,

- std::unique_ptr<WebMessagePortChannelArray> webChannels) {

- m_client.postMessageToClient(clientUUID, message, webChannels.release());

+ WebMessagePortChannelArray webChannels) {

+ m_client.postMessageToClient(clientUUID, message, std::move(webChannels));

}

void ServiceWorkerGlobalScopeClientImpl::skipWaiting(