third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp - Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)

Patch Set: Add missing ScopedAsyncTaskScheduler instance for the new unit tests; required by a recent change t… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

index 0e35aeb0d1f832bc905a81296b72355ea462aebd..fb3272ca97c5604dbc30b1fdda1efd92f4077d12 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.cpp

@@ -445,12 +445,12 @@ void ServiceWorkerContainer::setController(

void ServiceWorkerContainer::dispatchMessageEvent(

std::unique_ptr<WebServiceWorker::Handle> handle,

const WebString& message,

- const WebMessagePortChannelArray& webChannels) {

+ WebMessagePortChannelArray webChannels) {

if (!getExecutionContext() || !getExecutionContext()->executingWindow())

return;

- MessagePortArray* ports =

- MessagePort::toMessagePortArray(getExecutionContext(), webChannels);

+ MessagePortArray* ports = MessagePort::toMessagePortArray(

+ getExecutionContext(), std::move(webChannels));

RefPtr<SerializedScriptValue> value = SerializedScriptValue::create(message);

ServiceWorker* source = ServiceWorker::from(

getExecutionContext(), WTF::wrapUnique(handle.release()));