third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp - Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)

Patch Set: Add missing ScopedAsyncTaskScheduler instance for the new unit tests; required by a recent change t… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/serviceworkers/ServiceWorker.cpp ('k') | third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp

diff --git a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp

index d5a99c61128cdf872af99e1cca3821f5d7368ef3..7434831524dc0b1d1e99461b9c73253cb6efb3ab 100644

--- a/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp

+++ b/third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerClient.cpp

@@ -70,13 +70,13 @@ void ServiceWorkerClient::postMessage(ScriptState* scriptState,

ExceptionState& exceptionState) {

ExecutionContext* context = scriptState->getExecutionContext();

// Disentangle the port in preparation for sending it to the remote context.

- std::unique_ptr<MessagePortChannelArray> channels =

+ MessagePortChannelArray channels =

MessagePort::disentanglePorts(context, ports, exceptionState);

if (exceptionState.hadException())

return;

WebString messageString = message->toWireString();

- std::unique_ptr<WebMessagePortChannelArray> webChannels =

+ WebMessagePortChannelArray webChannels =

MessagePort::toWebMessagePortChannelArray(std::move(channels));

ServiceWorkerGlobalScopeClient::from(context)->postMessageToClient(

m_uuid, messageString, std::move(webChannels));