Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1111)

Unified Diff: content/common/fileapi/webblob_messages.h

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)
Patch Set: Add missing ScopedAsyncTaskScheduler instance for the new unit tests; required by a recent change t… Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/content_param_traits.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/fileapi/webblob_messages.h
diff --git a/content/common/fileapi/webblob_messages.h b/content/common/fileapi/webblob_messages.h
index 3b22b7f588e9883626dce4866b72e73a0f3fcb53..2d1caf26034b16bea21eaaa072fbaf3d59c38c05 100644
--- a/content/common/fileapi/webblob_messages.h
+++ b/content/common/fileapi/webblob_messages.h
@@ -54,11 +54,18 @@ IPC_STRUCT_TRAITS_END()
// * 'shortcut' transport the memory up to the IPC limit so the browser can use
// it if it's not currently full.
// See https://bit.ly/BlobStorageRefactor
-IPC_MESSAGE_CONTROL4(BlobStorageMsg_RegisterBlob,
- std::string /* uuid */,
- std::string /* content_type */,
- std::string /* content_disposition */,
- std::vector<storage::DataElement> /* item_descriptions */)
+//
+// NOTE: This message is synchronous to ensure that the browser is aware of the
+// UUID before the UUID is passed to another process. This protects against a
+// race condition in which the browser could be asked about a UUID that doesn't
+// yet exist from its perspective. See also https://goo.gl/bfdE64.
+//
+IPC_SYNC_MESSAGE_CONTROL4_0(
+ BlobStorageMsg_RegisterBlob,
+ std::string /* uuid */,
+ std::string /* content_type */,
+ std::string /* content_disposition */,
+ std::vector<storage::DataElement> /* item_descriptions */)
IPC_MESSAGE_CONTROL4(
BlobStorageMsg_RequestMemoryItem,
@@ -80,9 +87,13 @@ IPC_MESSAGE_CONTROL1(BlobHostMsg_IncrementRefCount,
std::string /* uuid */)
IPC_MESSAGE_CONTROL1(BlobHostMsg_DecrementRefCount,
std::string /* uuid */)
-IPC_MESSAGE_CONTROL2(BlobHostMsg_RegisterPublicURL,
- GURL,
- std::string /* uuid */)
+// NOTE: This message is synchronous to ensure that the browser is aware of the
+// UUID before the UUID is passed to another process. This protects against a
+// race condition in which the browser could be asked about a UUID that doesn't
+// yet exist from its perspective. See also https://goo.gl/bfdE64.
+IPC_SYNC_MESSAGE_CONTROL2_0(BlobHostMsg_RegisterPublicURL,
+ GURL,
+ std::string /* uuid */)
IPC_MESSAGE_CONTROL1(BlobHostMsg_RevokePublicURL,
GURL)
« no previous file with comments | « content/common/content_param_traits.cc ('k') | content/common/frame_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698