content/child/service_worker/service_worker_dispatcher_unittest.cc - Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/child/service_worker/service_worker_dispatcher_unittest.cc

Issue 2422793002: HTML MessagePort as mojo::MessagePipeHandle (Closed)

Patch Set: Add missing ScopedAsyncTaskScheduler instance for the new unit tests; required by a recent change t… Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/child/service_worker/service_worker_dispatcher_unittest.cc

diff --git a/content/child/service_worker/service_worker_dispatcher_unittest.cc b/content/child/service_worker/service_worker_dispatcher_unittest.cc

index 0f9b789ae84fada532426168052ed209d5ee5c72..ae0f55e717bb1f4fd9e5895d515a8d2149a6e6a8 100644

--- a/content/child/service_worker/service_worker_dispatcher_unittest.cc

+++ b/content/child/service_worker/service_worker_dispatcher_unittest.cc

@@ -138,7 +138,7 @@ class MockWebServiceWorkerProviderClientImpl

void dispatchMessageEvent(

std::unique_ptr<blink::WebServiceWorker::Handle> handle,

const blink::WebString& message,

- const blink::WebMessagePortChannelArray& channels) override {

+ blink::WebMessagePortChannelArray channels) override {

// WebPassOwnPtr cannot be owned in Chromium, so drop the handle here.

// The destruction releases ServiceWorkerHandleReference.

is_dispatch_message_event_called_ = true;