Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(601)

Issue 2422773004: [Media Router] Adds a pre-invocation hook to Media Router bindings. (Closed)

Created:
4 years, 2 months ago by mark a. foltz
Modified:
4 years, 1 month ago
Reviewers:
imcheng
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, extensions-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Media Router] Adds a pre-invocation hook to Media Router bindings. This hook allows the Media Router component to properly record the cause of event page wakeups that are caused by invoking the Media Route Provider API. BUG= Committed: https://crrev.com/8e100e892b381a7088ad6c48e6c6fd11acf9a246 Cr-Commit-Position: refs/heads/master@{#427097}

Patch Set 1 #

Patch Set 2 : Fix typo #

Total comments: 2

Patch Set 3 : Update comment & respond to imcheng@ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -4 lines) Patch
M extensions/renderer/resources/media_router_bindings.js View 1 2 19 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
mark a. foltz
Will wait to commit until a component that supports onBeforeInvokeHandler is available in canary, then ...
4 years, 2 months ago (2016-10-20 17:47:59 UTC) #2
imcheng
lgtm https://codereview.chromium.org/2422773004/diff/20001/extensions/renderer/resources/media_router_bindings.js File extensions/renderer/resources/media_router_bindings.js (right): https://codereview.chromium.org/2422773004/diff/20001/extensions/renderer/resources/media_router_bindings.js#newcode867 extensions/renderer/resources/media_router_bindings.js:867: sinkId, sourceUrn, searchCriteria) { nit: revert this line?
4 years, 2 months ago (2016-10-20 17:56:35 UTC) #3
mark a. foltz
https://codereview.chromium.org/2422773004/diff/20001/extensions/renderer/resources/media_router_bindings.js File extensions/renderer/resources/media_router_bindings.js (right): https://codereview.chromium.org/2422773004/diff/20001/extensions/renderer/resources/media_router_bindings.js#newcode867 extensions/renderer/resources/media_router_bindings.js:867: sinkId, sourceUrn, searchCriteria) { On 2016/10/20 at 17:56:35, imcheng ...
4 years, 1 month ago (2016-10-24 17:32:03 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422773004/40001
4 years, 1 month ago (2016-10-24 17:32:42 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 1 month ago (2016-10-24 18:07:02 UTC) #8
commit-bot: I haz the power
4 years, 1 month ago (2016-10-24 18:22:41 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/8e100e892b381a7088ad6c48e6c6fd11acf9a246
Cr-Commit-Position: refs/heads/master@{#427097}

Powered by Google App Engine
This is Rietveld 408576698