Improve Android accessible hit testing.

content/browser/accessibility/browser_accessibility_android.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_
 #define CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 30 matching lines @@
   bool IsHierarchical() const;
   bool IsLink() const;
   bool IsMultiLine() const;
   bool IsPassword() const;
   bool IsRangeType() const;
   bool IsScrollable() const;
   bool IsSelected() const;
   bool IsSlider() const;
   bool IsVisibleToUser() const;
 
+  // This returns true for all nodes that we should navigate to.
+  // Nodes that have a generic role, no accessible name, and aren't
+  // focusable or clickable aren't interesting.
+  bool IsInterestingOnAndroid() const;
+
+  // If this node isn't interesting, recursively checks all of the

[aboxhall, 2016/10/18 22:17:28]

This comment is missing a critical point, especially given the name gives the
same misleading idea: it's not strictly a descendant, it may be |this|.

[dmazzoni, 2016/10/19 23:00:45]

Ah, good point.

Renamed and reworded, take a look.

+  // platform children of this node, and if just a single one is
+  // interesting, returns that one.
+  const BrowserAccessibilityAndroid* GetSoleInterestingDescendant() const;
+
   bool CanOpenPopup() const;
 
   bool HasFocusableChild() const;
   bool HasNonEmptyValue() const;
 
   const char* GetClassName() const;
   base::string16 GetText() const override;
 
   base::string16 GetRoleDescription() const;
 
@@ skipping 84 matching lines @@
   bool first_time_;
   base::string16 old_value_;
   base::string16 new_value_;
 
   DISALLOW_COPY_AND_ASSIGN(BrowserAccessibilityAndroid);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_ACCESSIBILITY_BROWSER_ACCESSIBILITY_ANDROID_H_