Improve Android accessible hit testing.

content/browser/accessibility/browser_accessibility_android.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/accessibility/browser_accessibility_android.h"
 
 #include "base/i18n/break_iterator.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
@@ skipping 259 matching lines @@
 }
 
 bool BrowserAccessibilityAndroid::IsSlider() const {
   return GetRole() == ui::AX_ROLE_SLIDER;
 }
 
 bool BrowserAccessibilityAndroid::IsVisibleToUser() const {
   return !HasState(ui::AX_STATE_INVISIBLE);
 }
 
+bool BrowserAccessibilityAndroid::IsInterestingOnAndroid() const {
+  // Focusable nodes are always interesting. Note that IsFocusable()
+  // already skips over things like iframes and child frames that are
+  // technically focusable but shouldn't be exposed as focusable on Android.
+  if (IsFocusable())
+    return true;
+
+  // If it's not focusable but has a control role, then it's interesting.
+  if (IsControl())
+    return true;
+
+  // Otherwise, the interesting nodes are leaf nodes with text.
+  return PlatformIsLeaf() && !GetText().empty();
+}
+
+const BrowserAccessibilityAndroid*
+    BrowserAccessibilityAndroid::GetInterestingChild() const {

[aboxhall, 2016/10/18 21:03:24]

Trying to think of a less confusing name for this - it's not necessarily a
child, not necessarily a direct child, and doesn't necessarily return an
interesting child even if one exists.

Maybe something like "SoleInterestingNodeForSubtree"?

[dmazzoni, 2016/10/18 22:09:36]

Good idea, I changed it to GetSoleInterestingDescendant()

+  if (IsInterestingOnAndroid())
+    return this;
+
+  const BrowserAccessibilityAndroid* interesting_child = nullptr;
+  for (uint32_t i = 0; i < PlatformChildCount(); ++i) {
+    const BrowserAccessibilityAndroid* result =
+        static_cast<const BrowserAccessibilityAndroid*>(PlatformGetChild(i))->
+            GetInterestingChild();
+    if (result && interesting_child) {

[aboxhall, 2016/10/18 21:03:24]

Maybe s/result/interesting_child/ and
s/interesting_child/sole_interesting_child/ or similar?

[dmazzoni, 2016/10/18 22:09:36]

Done.

+      // If there are two interesting children, return nullptr
+      return nullptr;
+    } else if (result) {
+      interesting_child = result;
+    }
+  }
+
+  return interesting_child;
+}
+
 bool BrowserAccessibilityAndroid::CanOpenPopup() const {
   return HasState(ui::AX_STATE_HASPOPUP);
 }
 
 const char* BrowserAccessibilityAndroid::GetClassName() const {
   const char* class_name = NULL;
 
   switch (GetRole()) {
     case ui::AX_ROLE_SEARCH_BOX:
     case ui::AX_ROLE_SPIN_BUTTON:
@@ skipping 1138 matching lines @@
 int BrowserAccessibilityAndroid::CountChildrenWithRole(ui::AXRole role) const {
   int count = 0;
   for (uint32_t i = 0; i < PlatformChildCount(); i++) {
     if (PlatformGetChild(i)->GetRole() == role)
       count++;
   }
   return count;
 }
 
 }  // namespace content