Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2422703002:
First run: tweaks to welcome page (Closed)
DescriptionFirst run: tweaks to welcome page
1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker
2) Change rotate to counter-clockwise to match "saw" look of logo
3) Add a spin on click (just like chrome://help)
4) Move <script> to end of <body> to not block loading
5) Change some font sizes and border-radius for UX peeps
6) Hide watermark on short screens
R=tmartino@chromium.org
BUG=650778, 656096
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
Committed: https://crrev.com/2853699597db022e09794d623453e55acec80d96
Cr-Commit-Position: refs/heads/master@{#425478}
Patch Set 1 #Patch Set 2 : script #Patch Set 3 : revert .class -> #id #
Messages
Total messages: 22 (16 generated)
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) R=tmartino@chromium.org BUG=650778 ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) change a bunch of single instances of .class to #id R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) change a bunch of single instances of .class to #id R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Change a bunch of single instances of .class to #id R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Change a bunch of single instances of .class to #id R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Change a bunch of single instances of .class to #id 5) Move <script> to end of <body> to not block loading R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Thanks for tackling some of these improvements! The help is a very welcome surprise :) Can you also incorporate these tweaks that are outstanding from UX review? https://codereview.chromium.org/2418083003
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Change a bunch of single instances of .class to #id 5) Move <script> to end of <body> to not block loading R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
On 2016/10/14 19:19:02, tmartino wrote: > Thanks for tackling some of these improvements! The help is a very welcome > surprise :) > > Can you also incorporate these tweaks that are outstanding from UX review? > https://codereview.chromium.org/2418083003 Done.
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps 6) Hide watermark on short screens R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
The CQ bit was checked by dbeam@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
lgtm
The CQ bit was unchecked by dbeam@chromium.org
The CQ bit was checked by dbeam@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps 6) Hide watermark on short screens R=tmartino@chromium.org BUG=650778 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps 6) Hide watermark on short screens R=tmartino@chromium.org BUG=650778,656096 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps 6) Hide watermark on short screens R=tmartino@chromium.org BUG=650778,656096 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps 6) Hide watermark on short screens R=tmartino@chromium.org BUG=650778,656096 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ==========
Message was sent while issue was closed.
Committed patchset #3 (id:40001)
Message was sent while issue was closed.
Description was changed from ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps 6) Hide watermark on short screens R=tmartino@chromium.org BUG=650778,656096 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation ========== to ========== First run: tweaks to welcome page 1) Preload bold Roboto so tabbing to "SIGN IN" doesn't flicker 2) Change rotate to counter-clockwise to match "saw" look of logo 3) Add a spin on click (just like chrome://help) 4) Move <script> to end of <body> to not block loading 5) Change some font sizes and border-radius for UX peeps 6) Hide watermark on short screens R=tmartino@chromium.org BUG=650778,656096 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/2853699597db022e09794d623453e55acec80d96 Cr-Commit-Position: refs/heads/master@{#425478} ==========
Message was sent while issue was closed.
Patchset 3 (id:??) landed as https://crrev.com/2853699597db022e09794d623453e55acec80d96 Cr-Commit-Position: refs/heads/master@{#425478} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
