[MIPS] Add support to gyp files to build Native Client inside of Chromium

[MIPS] Add support to gyp files to build Native Client inside of Chromium

Update the native client gyp files with support for MIPS.

Committed on behalf of Petar Jovanovic (petarj@mips.com), because the
Commit Queue's presubmit checks are failing on this change.
(For the gory details, see: http://code.google.com/p/chromium/issues/detail?id=303837)

BUG= no support in build files for MIPS
TEST= build Chromium with Native Client

TBR=jfb@chromium.org
(for the validator_arm change)

Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=12233

[petarj, 2013-09-20 17:16:40]

PTAL.

[Mark Seaborn, 2013-09-20 23:11:17]

Some initial comments...

https://codereview.chromium.org/24227003/diff/1/build/build_nexe.py
File build/build_nexe.py (right):

https://codereview.chromium.org/24227003/diff/1/build/build_nexe.py#newcode187
build/build_nexe.py:187: ErrOut('mips glibc not supported.')
The surrounding code uses "raise Error"

https://codereview.chromium.org/24227003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/24227003/diff/1/build/common.gypi#newcode209
build/common.gypi:209: 'NACL_BUILD_ARCH=mipsel',
Why not "mips" instead of "mipsel"?  Then we don't need the nacl_base.h change.

https://codereview.chromium.org/24227003/diff/1/build/common.gypi#newcode353
build/common.gypi:353: 'cflags': ['-mips32r2'],
Indent by 1 fewer space (i.e. 2 spaces per indentation level)

https://codereview.chromium.org/24227003/diff/1/build/common.gypi#newcode355
build/common.gypi:355: 'cflags': ['-mips32'],
Same here

https://codereview.chromium.org/24227003/diff/1/src/trusted/service_runtime/s...
File src/trusted/service_runtime/service_runtime.gyp (right):

https://codereview.chromium.org/24227003/diff/1/src/trusted/service_runtime/s...
src/trusted/service_runtime/service_runtime.gyp:183: 'arch/mips/nacl_app.c',
Please sort this list

https://codereview.chromium.org/24227003/diff/1/src/trusted/validator/ncfileu...
File src/trusted/validator/ncfileutils.gyp (right):

https://codereview.chromium.org/24227003/diff/1/src/trusted/validator/ncfileu...
src/trusted/validator/ncfileutils.gyp:71: 'targets': [],
This is presumably just a no-op?  Can you omit it, and maybe remove the ARM
no-op too?  Or does Gyp complain if 'targets' is undefined?

[petarj, 2013-09-23 17:49:24]

New patch set uploaded. PTAL.

https://codereview.chromium.org/24227003/diff/1/build/build_nexe.py
File build/build_nexe.py (right):

https://codereview.chromium.org/24227003/diff/1/build/build_nexe.py#newcode187
build/build_nexe.py:187: ErrOut('mips glibc not supported.')
On 2013/09/20 23:11:17, Mark Seaborn wrote:
> The surrounding code uses "raise Error"

Done.

https://codereview.chromium.org/24227003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/24227003/diff/1/build/common.gypi#newcode209
build/common.gypi:209: 'NACL_BUILD_ARCH=mipsel',
On 2013/09/20 23:11:17, Mark Seaborn wrote:
> Why not "mips" instead of "mipsel"?  Then we don't need the nacl_base.h
change.

Done.

https://codereview.chromium.org/24227003/diff/1/build/common.gypi#newcode353
build/common.gypi:353: 'cflags': ['-mips32r2'],
On 2013/09/20 23:11:17, Mark Seaborn wrote:
> Indent by 1 fewer space (i.e. 2 spaces per indentation level)

Done.

https://codereview.chromium.org/24227003/diff/1/build/common.gypi#newcode355
build/common.gypi:355: 'cflags': ['-mips32'],
On 2013/09/20 23:11:17, Mark Seaborn wrote:
> Same here

Done.

https://codereview.chromium.org/24227003/diff/1/src/trusted/service_runtime/s...
File src/trusted/service_runtime/service_runtime.gyp (right):

https://codereview.chromium.org/24227003/diff/1/src/trusted/service_runtime/s...
src/trusted/service_runtime/service_runtime.gyp:183: 'arch/mips/nacl_app.c',
On 2013/09/20 23:11:17, Mark Seaborn wrote:
> Please sort this list

Done.

https://codereview.chromium.org/24227003/diff/1/src/trusted/validator/ncfileu...
File src/trusted/validator/ncfileutils.gyp (right):

https://codereview.chromium.org/24227003/diff/1/src/trusted/validator/ncfileu...
src/trusted/validator/ncfileutils.gyp:71: 'targets': [],
On 2013/09/20 23:11:17, Mark Seaborn wrote:
> This is presumably just a no-op?  Can you omit it, and maybe remove the ARM
> no-op too?  Or does Gyp complain if 'targets' is undefined?

Done.

[Mark Seaborn, 2013-09-23 19:15:28]

https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi
File build/untrusted.gypi (right):

https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi#newc...
build/untrusted.gypi:755: # mips newlib library action
I'm comparing this with the target_arch=="arm" section.  That starts with "arm
newlib nexe action", but there's no corresponding part here.  Is there a reason
for omitting that?  Can you make this consistent, please?

https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi#newc...
build/untrusted.gypi:829: '--link_flags= -arch mips --pnacl-allow-translate
--pnacl-allow-native -Wt,-mtls-use-call --pnacl-disable-abi-check
-Wn,--section-start=.rodata=<(NACL_IRT_DATA_START)
-Wn,--section-start=.text=<(NACL_IRT_TEXT_START) -B>(tc_lib_dir_irt_mips)
^(link_flags) >(_link_flags)',
Why do you need "--pnacl-disable-abi-check" here?

The x86-64 version uses "-Wl,-Trodata-segment=<(NACL_IRT_DATA_START)
-Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)".  Can you use that rather than
"--section-start=.rodata" (which is usually less reliable)?  If not, can you
explain why in a comment?

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
File src/trusted/validator/x86/32/validator_x86_32.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
src/trusted/validator/x86/32/validator_x86_32.gyp:83: 'targets': []
Please just remove this 'targets':[] part, since it's a no-op.

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
File src/trusted/validator/x86/64/validator_x86_64.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
src/trusted/validator/x86/64/validator_x86_64.gyp:90: 'targets': []
Ditto: Please just remove this 'targets':[] part, since it's a no-op.

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
File src/trusted/validator/x86/decoder/ncval_x86_decoder.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
src/trusted/validator/x86/decoder/ncval_x86_decoder.gyp:178: 'targets': []
Please just remove these 'targets':[] parts

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_mip...
File src/trusted/validator_mips/validator_mips.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_mip...
src/trusted/validator_mips/validator_mips.gyp:93: 'sources': [ 'ncvalidate.cc'
],
Nit: Python spacing style is "[foo]" not "[ foo ]" for lists

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
File src/trusted/validator_ragel/dfa_validator_x86_32.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
src/trusted/validator_ragel/dfa_validator_x86_32.gyp:27: 'targets': []
Please just remove this 'targets':[] part

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
File src/trusted/validator_ragel/dfa_validator_x86_64.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
src/trusted/validator_ragel/dfa_validator_x86_64.gyp:36: 'targets': []
Ditto

[petarj, 2013-09-25 23:21:31]

https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi
File build/untrusted.gypi (right):

https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi#newc...
build/untrusted.gypi:755: # mips newlib library action
On 2013/09/23 19:15:28, Mark Seaborn wrote:
> I'm comparing this with the target_arch=="arm" section.  That starts with "arm
> newlib nexe action", but there's no corresponding part here.  Is there a
reason
> for omitting that?  Can you make this consistent, please?

We planned that to be part of a different patch, but nevertheless, it is
added in the new patch set to this CL. Done.

https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi#newc...
build/untrusted.gypi:829: '--link_flags= -arch mips --pnacl-allow-translate
--pnacl-allow-native -Wt,-mtls-use-call --pnacl-disable-abi-check
-Wn,--section-start=.rodata=<(NACL_IRT_DATA_START)
-Wn,--section-start=.text=<(NACL_IRT_TEXT_START) -B>(tc_lib_dir_irt_mips)
^(link_flags) >(_link_flags)',
On 2013/09/23 19:15:28, Mark Seaborn wrote:
> Why do you need "--pnacl-disable-abi-check" here?

This is needed for two reasons when we build IRT.NEXE:
1. GetProgramCounter() in base/location.cc needs __builtin_return_address.
2. inline assembly is present in some Chromium files that get included.

> The x86-64 version uses "-Wl,-Trodata-segment=<(NACL_IRT_DATA_START)
> -Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)".  Can you use that rather than
> "--section-start=.rodata" (which is usually less reliable)?

Done.

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
File src/trusted/validator/x86/32/validator_x86_32.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
src/trusted/validator/x86/32/validator_x86_32.gyp:83: 'targets': []
On 2013/09/23 19:15:28, Mark Seaborn wrote:
> Please just remove this 'targets':[] part, since it's a no-op.

Done.

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
File src/trusted/validator/x86/64/validator_x86_64.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
src/trusted/validator/x86/64/validator_x86_64.gyp:90: 'targets': []
On 2013/09/23 19:15:28, Mark Seaborn wrote:
> Ditto: Please just remove this 'targets':[] part, since it's a no-op.

Done.

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
File src/trusted/validator/x86/decoder/ncval_x86_decoder.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
src/trusted/validator/x86/decoder/ncval_x86_decoder.gyp:178: 'targets': []
On 2013/09/23 19:15:28, Mark Seaborn wrote:
> Please just remove these 'targets':[] parts

Done.

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_mip...
File src/trusted/validator_mips/validator_mips.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_mip...
src/trusted/validator_mips/validator_mips.gyp:93: 'sources': [ 'ncvalidate.cc'
],
On 2013/09/23 19:15:28, Mark Seaborn wrote:
> Nit: Python spacing style is "[foo]" not "[ foo ]" for lists

Done.

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
File src/trusted/validator_ragel/dfa_validator_x86_32.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
src/trusted/validator_ragel/dfa_validator_x86_32.gyp:27: 'targets': []
On 2013/09/23 19:15:28, Mark Seaborn wrote:
> Please just remove this 'targets':[] part

Done.

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
File src/trusted/validator_ragel/dfa_validator_x86_64.gyp (right):

https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
src/trusted/validator_ragel/dfa_validator_x86_64.gyp:36: 'targets': []
On 2013/09/23 19:15:28, Mark Seaborn wrote:
> Ditto

Done.

[petarj, 2013-09-28 01:20:47]

On 2013/09/25 23:21:31, petarj wrote:
> https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi
> File build/untrusted.gypi (right):
> 
>
https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi#newc...
> build/untrusted.gypi:755: # mips newlib library action
> On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > I'm comparing this with the target_arch=="arm" section.  That starts with
"arm
> > newlib nexe action", but there's no corresponding part here.  Is there a
> reason
> > for omitting that?  Can you make this consistent, please?
> 
> We planned that to be part of a different patch, but nevertheless, it is
> added in the new patch set to this CL. Done.
> 
>
https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi#newc...
> build/untrusted.gypi:829: '--link_flags= -arch mips --pnacl-allow-translate
> --pnacl-allow-native -Wt,-mtls-use-call --pnacl-disable-abi-check
> -Wn,--section-start=.rodata=<(NACL_IRT_DATA_START)
> -Wn,--section-start=.text=<(NACL_IRT_TEXT_START) -B>(tc_lib_dir_irt_mips)
> ^(link_flags) >(_link_flags)',
> On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > Why do you need "--pnacl-disable-abi-check" here?
> 
> This is needed for two reasons when we build IRT.NEXE:
> 1. GetProgramCounter() in base/location.cc needs __builtin_return_address.
> 2. inline assembly is present in some Chromium files that get included.
> 
> > The x86-64 version uses "-Wl,-Trodata-segment=<(NACL_IRT_DATA_START)
> > -Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)".  Can you use that rather than
> > "--section-start=.rodata" (which is usually less reliable)?
> 
> Done.
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> File src/trusted/validator/x86/32/validator_x86_32.gyp (right):
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> src/trusted/validator/x86/32/validator_x86_32.gyp:83: 'targets': []
> On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > Please just remove this 'targets':[] part, since it's a no-op.
> 
> Done.
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> File src/trusted/validator/x86/64/validator_x86_64.gyp (right):
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> src/trusted/validator/x86/64/validator_x86_64.gyp:90: 'targets': []
> On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > Ditto: Please just remove this 'targets':[] part, since it's a no-op.
> 
> Done.
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> File src/trusted/validator/x86/decoder/ncval_x86_decoder.gyp (right):
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> src/trusted/validator/x86/decoder/ncval_x86_decoder.gyp:178: 'targets': []
> On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > Please just remove these 'targets':[] parts
> 
> Done.
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_mip...
> File src/trusted/validator_mips/validator_mips.gyp (right):
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_mip...
> src/trusted/validator_mips/validator_mips.gyp:93: 'sources': [ 'ncvalidate.cc'
> ],
> On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > Nit: Python spacing style is "[foo]" not "[ foo ]" for lists
> 
> Done.
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
> File src/trusted/validator_ragel/dfa_validator_x86_32.gyp (right):
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
> src/trusted/validator_ragel/dfa_validator_x86_32.gyp:27: 'targets': []
> On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > Please just remove this 'targets':[] part
> 
> Done.
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
> File src/trusted/validator_ragel/dfa_validator_x86_64.gyp (right):
> 
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
> src/trusted/validator_ragel/dfa_validator_x86_64.gyp:36: 'targets': []
> On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > Ditto
> 
> Done.

ping.

[petarj, 2013-10-01 17:50:59]

On 2013/09/28 01:20:47, petarj wrote:
> On 2013/09/25 23:21:31, petarj wrote:
> > https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi
> > File build/untrusted.gypi (right):
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi#newc...
> > build/untrusted.gypi:755: # mips newlib library action
> > On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > > I'm comparing this with the target_arch=="arm" section.  That starts with
> "arm
> > > newlib nexe action", but there's no corresponding part here.  Is there a
> > reason
> > > for omitting that?  Can you make this consistent, please?
> > 
> > We planned that to be part of a different patch, but nevertheless, it is
> > added in the new patch set to this CL. Done.
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/build/untrusted.gypi#newc...
> > build/untrusted.gypi:829: '--link_flags= -arch mips --pnacl-allow-translate
> > --pnacl-allow-native -Wt,-mtls-use-call --pnacl-disable-abi-check
> > -Wn,--section-start=.rodata=<(NACL_IRT_DATA_START)
> > -Wn,--section-start=.text=<(NACL_IRT_TEXT_START) -B>(tc_lib_dir_irt_mips)
> > ^(link_flags) >(_link_flags)',
> > On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > > Why do you need "--pnacl-disable-abi-check" here?
> > 
> > This is needed for two reasons when we build IRT.NEXE:
> > 1. GetProgramCounter() in base/location.cc needs __builtin_return_address.
> > 2. inline assembly is present in some Chromium files that get included.
> > 
> > > The x86-64 version uses "-Wl,-Trodata-segment=<(NACL_IRT_DATA_START)
> > > -Wl,-Ttext-segment=<(NACL_IRT_TEXT_START)".  Can you use that rather than
> > > "--section-start=.rodata" (which is usually less reliable)?
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> > File src/trusted/validator/x86/32/validator_x86_32.gyp (right):
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> > src/trusted/validator/x86/32/validator_x86_32.gyp:83: 'targets': []
> > On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > > Please just remove this 'targets':[] part, since it's a no-op.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> > File src/trusted/validator/x86/64/validator_x86_64.gyp (right):
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> > src/trusted/validator/x86/64/validator_x86_64.gyp:90: 'targets': []
> > On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > > Ditto: Please just remove this 'targets':[] part, since it's a no-op.
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> > File src/trusted/validator/x86/decoder/ncval_x86_decoder.gyp (right):
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator/x86...
> > src/trusted/validator/x86/decoder/ncval_x86_decoder.gyp:178: 'targets': []
> > On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > > Please just remove these 'targets':[] parts
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_mip...
> > File src/trusted/validator_mips/validator_mips.gyp (right):
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_mip...
> > src/trusted/validator_mips/validator_mips.gyp:93: 'sources': [
'ncvalidate.cc'
> > ],
> > On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > > Nit: Python spacing style is "[foo]" not "[ foo ]" for lists
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
> > File src/trusted/validator_ragel/dfa_validator_x86_32.gyp (right):
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
> > src/trusted/validator_ragel/dfa_validator_x86_32.gyp:27: 'targets': []
> > On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > > Please just remove this 'targets':[] part
> > 
> > Done.
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
> > File src/trusted/validator_ragel/dfa_validator_x86_64.gyp (right):
> > 
> >
>
https://codereview.chromium.org/24227003/diff/33001/src/trusted/validator_rag...
> > src/trusted/validator_ragel/dfa_validator_x86_64.gyp:36: 'targets': []
> > On 2013/09/23 19:15:28, Mark Seaborn wrote:
> > > Ditto
> > 
> > Done.
> 
> ping.

ping

[Mark Seaborn, 2013-10-02 17:07:51]

LGTM

[commit-bot: I haz the power, 2013-10-02 22:48:13]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/76001

[commit-bot: I haz the power, 2013-10-02 22:48:20]

Presubmit check for 24227003-76001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[commit-bot: I haz the power, 2013-10-02 23:05:27]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/126001

[commit-bot: I haz the power, 2013-10-02 23:05:35]

Presubmit check for 24227003-126001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[petarj, 2013-10-02 23:15:08]

On 2013/10/02 23:05:35, I haz the power (commit-bot) wrote:
> Presubmit check for 24227003-126001 failed and returned exit status 1.
> 
> Running presubmit commit checks ...
> Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
>   Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
> such file or directory 
> Traceback (most recent call last):
>   File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
>     sys.exit(presubmit_support.Main(argv))
>   File "/b/depot_tools/presubmit_support.py", line 1421, in Main
>     rietveld_obj)
>   File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
>     results += executer.ExecPresubmitScript(presubmit_script, filename)
>   File "/b/depot_tools/presubmit_support.py", line 1141, in
ExecPresubmitScript
>     result = eval(function_name + '(*__args)', context)
>   File "<string>", line 1, in <module>
>   File "<string>", line 114, in CheckChangeOnCommit
>   File "<string>", line 44, in CheckChange
>   File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
>     changelists = self._GetChangeLists()
>   File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
>     self._changelists = gcl.GetModifiedFiles()
>   File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
>     for cl in GetCLs():
>   File "/b/depot_tools/gcl.py", line 628, in GetCLs
>     cls = os.listdir(GetChangesDir())
> OSError: [Errno 2] No such file or directory:
> '/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

Is anybody familiar with this error?

Thanks.
Petar

[commit-bot: I haz the power, 2013-10-03 00:23:59]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/126001

[commit-bot: I haz the power, 2013-10-03 00:24:08]

Presubmit check for 24227003-126001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[commit-bot: I haz the power, 2013-10-03 11:58:04]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/126001

[commit-bot: I haz the power, 2013-10-03 11:58:14]

Presubmit check for 24227003-126001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[commit-bot: I haz the power, 2013-10-03 18:28:45]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/126001

[commit-bot: I haz the power, 2013-10-03 18:28:56]

Presubmit check for 24227003-126001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[Derek Schuff, 2013-10-03 19:54:30]

CQ looks busted. I'll try NOTRY=true
(although I don't remember whether it still runs the presubmit or not)

[commit-bot: I haz the power, 2013-10-03 19:54:40]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/126001

[commit-bot: I haz the power, 2013-10-03 19:55:02]

Presubmit check for 24227003-126001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[commit-bot: I haz the power, 2013-10-03 23:25:16]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/126001

[commit-bot: I haz the power, 2013-10-03 23:25:26]

Presubmit check for 24227003-126001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[Mark Seaborn, 2013-10-03 23:38:08]

On 3 October 2013 12:54, <dschuff@chromium.org> wrote:

> CQ looks busted. I'll try NOTRY=true
> (although I don't remember whether it still runs the presubmit or not)


I filed this issue, in which maruel proposes a fix:
http://code.google.com/p/chromium/issues/detail?id=303837

Mark

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.

[commit-bot: I haz the power, 2013-10-04 16:42:51]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/126001

[commit-bot: I haz the power, 2013-10-04 16:43:00]

Presubmit check for 24227003-126001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[commit-bot: I haz the power, 2013-10-05 15:57:47]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/169001

[commit-bot: I haz the power, 2013-10-05 15:57:56]

Presubmit check for 24227003-169001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[petarj, 2013-10-09 01:25:00]

Can someone with commit rights commit this directly?

Thanks in advance.

Petar

[commit-bot: I haz the power, 2013-10-10 22:01:35]

CQ is trying da patch. Follow status at
https://nativeclient-status.appspot.com/cq/petarj@mips.com/24227003/169001

[commit-bot: I haz the power, 2013-10-10 22:01:44]

Presubmit check for 24227003-169001 failed and returned exit status 1.

Running presubmit commit checks ...
Error processing /b/commit-queue/workdir/nacl/build/build_nexe.py:
  Cannot execute command ['pychecker', '-stdlib']. failed reason: [Errno 2] No
such file or directory 
Traceback (most recent call last):
  File "/b/commit-queue/verification/presubmit_shim.py", line 33, in <module>
    sys.exit(presubmit_support.Main(argv))
  File "/b/depot_tools/presubmit_support.py", line 1421, in Main
    rietveld_obj)
  File "/b/depot_tools/presubmit_support.py", line 1224, in DoPresubmitChecks
    results += executer.ExecPresubmitScript(presubmit_script, filename)
  File "/b/depot_tools/presubmit_support.py", line 1141, in ExecPresubmitScript
    result = eval(function_name + '(*__args)', context)
  File "<string>", line 1, in <module>
  File "<string>", line 114, in CheckChangeOnCommit
  File "<string>", line 44, in CheckChange
  File "/b/depot_tools/presubmit_support.py", line 933, in GetAllModifiedFiles
    changelists = self._GetChangeLists()
  File "/b/depot_tools/presubmit_support.py", line 927, in _GetChangeLists
    self._changelists = gcl.GetModifiedFiles()
  File "/b/depot_tools/gcl.py", line 663, in GetModifiedFiles
    for cl in GetCLs():
  File "/b/depot_tools/gcl.py", line 628, in GetCLs
    cls = os.listdir(GetChangesDir())
OSError: [Errno 2] No such file or directory:
'/b/commit-queue/workdir/nacl/.svn/gcl_info/changes'

[Mark Seaborn, 2013-10-11 00:10:35]

Committed patchset #5 manually as r12233 (presubmit successful).

[Mark Seaborn, 2013-10-11 00:11:52]

+JF/Karl: Could you sign off on the change to
src/trusted/validator_arm/ncval.gyp?  I committed that small part TBR because it
was a trivial cleanup.

[JF, 2013-10-11 02:23:01]

Lgtm
 On Oct 10, 2013 5:11 PM, <mseaborn@chromium.org> wrote:

> +JF/Karl: Could you sign off on the change to
> src/trusted/validator_arm/**ncval.gyp?  I committed that small part TBR
> because it
> was a trivial cleanup.
>
>
https://codereview.chromium.**org/24227003/<https://codereview.chromium.org/2...
>

-- 
You received this message because you are subscribed to the Google Groups
"Native-Client-Reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to native-client-reviews+unsubscribe@googlegroups.com.
To post to this group, send email to native-client-reviews@googlegroups.com.
Visit this group at http://groups.google.com/group/native-client-reviews.
For more options, visit https://groups.google.com/groups/opt_out.