Modify 'build_dir' for run_mb() to avoid double 'Debug'

Modify 'build_dir' for run_mb() to avoid double 'Debug'

Fix issue with double 'Debug' after CL = 	
2415963004

ninja: fatal: chdir to '/b/build/slave/Blimp_Client_Engine_Integration/build/src/out-linux/Debug/Debug' - No such file or directory
https://build.chromium.org/p/chromium.fyi/builders/Blimp%20Client%20Engine%20Integration/builds/160/steps/compile/logs/stdio


BUG=655864
Committed: https://chromium.googlesource.com/chromium/tools/build/+/dd839c91b9b2e7f1b45683dfe1e7ac68f01157a6

[shenghuazhang, 2016-10-14 21:35:58]

Description was changed from

==========
Modify 'build_dir' for run_mb() to avoid double 'Debug'

BUG=655864
==========

to

==========
Modify 'build_dir' for run_mb() to avoid double 'Debug'

Fix issue with double 'Debug' after CL = 	
2415963004

ninja: fatal: chdir to
'/b/build/slave/Blimp_Client_Engine_Integration/build/src/out-linux/Debug/Debug'
- No such file or directory
https://build.chromium.org/p/chromium.fyi/builders/Blimp%20Client%20Engine%20...


BUG=655864
==========

[shenghuazhang, 2016-10-14 21:41:22]

shenghuazhang@chromium.org changed reviewers:
+ mikecase@chromium.org

[shenghuazhang, 2016-10-14 21:41:23]

Seems like the '--target' would be a redundancy to be either 'Debug' or
'Release'. I ugly modified the path in this CL.

https://codereview.chromium.org/2422653003/diff/20001/scripts/slave/recipes/b...
File scripts/slave/recipes/blimp/integration.py (right):

https://codereview.chromium.org/2422653003/diff/20001/scripts/slave/recipes/b...
scripts/slave/recipes/blimp/integration.py:60: android_build =
api.path['checkout'].join('out-android')
Remove 'Debug' here to avoid double 'Debug' when execute api.chromium.compile

https://codereview.chromium.org/2422653003/diff/20001/scripts/slave/recipes/b...
scripts/slave/recipes/blimp/integration.py:68:
api.chromium.compile(targets=['blimp'],
api.chromium.compile would add '--target' anyway:

https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/...

Have to ensure the 'out_dir' without 'Debug':
https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/...

Then the final path equals to the one in api.chromium.run_mb --
build_dir=linux_build.join(api.chromium.c.build_config_fs)

[mikecase (-- gone --), 2016-10-14 21:44:47]

lgtm

https://codereview.chromium.org/2422653003/diff/20001/scripts/slave/recipes/b...
File scripts/slave/recipes/blimp/integration.py (right):

https://codereview.chromium.org/2422653003/diff/20001/scripts/slave/recipes/b...
scripts/slave/recipes/blimp/integration.py:60: android_build =
api.path['checkout'].join('out-android')
On 2016/10/14 at 21:41:23, shenghuazhang1 wrote:
> Remove 'Debug' here to avoid double 'Debug' when execute api.chromium.compile

yup, seems like you need to do this.

[shenghuazhang, 2016-10-14 21:45:34]

The CQ bit was checked by shenghuazhang@chromium.org

[commit-bot: I haz the power, 2016-10-14 21:45:45]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-14 22:04:31]

Description was changed from

==========
Modify 'build_dir' for run_mb() to avoid double 'Debug'

Fix issue with double 'Debug' after CL = 	
2415963004

ninja: fatal: chdir to
'/b/build/slave/Blimp_Client_Engine_Integration/build/src/out-linux/Debug/Debug'
- No such file or directory
https://build.chromium.org/p/chromium.fyi/builders/Blimp%20Client%20Engine%20...


BUG=655864
==========

to

==========
Modify 'build_dir' for run_mb() to avoid double 'Debug'

Fix issue with double 'Debug' after CL = 	
2415963004

ninja: fatal: chdir to
'/b/build/slave/Blimp_Client_Engine_Integration/build/src/out-linux/Debug/Debug'
- No such file or directory
https://build.chromium.org/p/chromium.fyi/builders/Blimp%20Client%20Engine%20...


BUG=655864

Committed:
https://chromium.googlesource.com/chromium/tools/build/+/dd839c91b9b2e7f1b456...
==========

[commit-bot: I haz the power, 2016-10-14 22:04:32]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/dd839c91b9b2e7f1b456...