Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(147)

Issue 2422643003: Prepare for new EvaluateScript event coming from V8. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
Reviewers:
caseq
CC:
apavlov+blink_chromium.org, blink-reviews, caseq+blink_chromium.org, chromium-reviews, devtools-reviews_chromium.org, kozyatinskiy+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Prepare for new EvaluateScript event coming from V8. BUG=655430 TBR=caseq@chromium.org NOTRY=true Committed: https://crrev.com/799eabe2822ffaea3ca8c841d5bca1fbb9fbc979 Cr-Commit-Position: refs/heads/master@{#425398}

Patch Set 1 #

Total comments: 1

Patch Set 2 : DevTools: Prepare to new EvaluateScript event coming from V8. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +7 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (8 generated)
alph
4 years, 2 months ago (2016-10-14 18:05:40 UTC) #2
caseq
https://codereview.chromium.org/2422643003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js File third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js (right): https://codereview.chromium.org/2422643003/diff/1/third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js#newcode336 third_party/WebKit/LayoutTests/http/tests/inspector/timeline-test.js:336: var data = traceEvent.args && (traceEvent.args["beginData"] || traceEvent.args["data"]); This ...
4 years, 2 months ago (2016-10-14 18:08:44 UTC) #3
alph
ptal
4 years, 2 months ago (2016-10-14 18:26:53 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2422643003/20001
4 years, 2 months ago (2016-10-14 18:29:48 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-10-14 18:37:14 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-14 18:38:51 UTC) #14
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/799eabe2822ffaea3ca8c841d5bca1fbb9fbc979
Cr-Commit-Position: refs/heads/master@{#425398}

Powered by Google App Engine
This is Rietveld 408576698